Add Docker samples for easy onboarding#120
Open
zawadzkidiana wants to merge 3 commits intocadence-workflow:masterfrom
Open
Add Docker samples for easy onboarding#120zawadzkidiana wants to merge 3 commits intocadence-workflow:masterfrom
zawadzkidiana wants to merge 3 commits intocadence-workflow:masterfrom
Conversation
Add containerized hello world workflow with Dockerfile and k8s deployment manifest. Signed-off-by: Diana Zawadzki <dzawa@live.de>
- Created docker-samples directory with standalone Docker-focused samples - Added hello-world sample with environment variable configuration - Created docker-compose.yml orchestrating Cadence server + sample workers - Added quick-start.sh script for one-command demo - Added comprehensive documentation for Docker workflows - Implemented multi-stage Docker build for minimal image size - Added build optimization with .dockerignore This enables running Cadence samples in containers, making it easier for users to get started without local setup. The samples include: - Basic workflow and activity execution - Long-running workflow examples - Environment-based configuration - Production-ready Docker patterns The docker-samples directory is self-contained and can be used independently of the existing samples for quick demonstrations. --- Note: This work was originally started in the wrong repository (cadence instead of cadence-samples) as I'm new to the team. After discussion with David and Ender, we agreed to relocate these files to the correct location. This commit represents that migration - moving the dockerization work from the cadence repo to cadence-samples where it belongs. This was my first project in Cadence, serving as a learning exercise to understand the workflow system while creating a quick-start Docker setup.
Addressing @timl3136's feedback: 1. Removed long_running_example.go - The main samples repo already has 20+ comprehensive workflow examples - Keeping docker-samples minimal and focused on quick onboarding - Added note in README directing users to main samples for more examples 2. Fixed all machine-specific paths - Changed '/path/to/cadence/samples' to 'docker-samples' - Removed GOWORK=off flag (not needed in standalone samples) - Made all paths relative and portable 3. Updated documentation - Clarified that docker-samples is intentionally standalone - Referenced main samples directory for advanced patterns - Improved quick-start instructions The docker-samples directory now serves as a minimal, self-contained quick-start for Docker users, while the main samples directory provides comprehensive examples for learning advanced Cadence patterns.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds docker-samples directory for quick Cadence onboarding with Docker.
What's included
Note
Originally opened in wrong repo (cadence instead of cadence-samples).
All feedback from initial review has been addressed: