-
Notifications
You must be signed in to change notification settings - Fork 880
ci: Add pull request reviewer via gitar #7649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Code Review ✅ ApprovedClean configuration-only PR that adds a well-structured gitar rule for automated PR description quality review. The file follows proper conventions with clear evaluation criteria, concrete examples, and pragmatic quality checks to avoid false positives. Rules ✅ All requirements metRepository Rules
OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |
|
[What changed?]: Expand technical details DetailsCurrent: "Adds guitar rule." Recommended: "Adds gitar rule configuration at The PR template guidance shows good examples include technical specifics and issue links where relevant. [Why?]: Provide full context and motivation DetailsCurrent: "Needed it." Recommended: Explain the problem being solved, the use case, and why this approach was chosen. For example:
The PR template emphasizes explaining WHY changes were made (see https://cbea.ms/git-commit/#why-not-how). [How did you test it?]: Include concrete test commands DetailsCurrent: "N/A" Recommended: Provide specific test commands or steps, such as:
Template requires exact commands that reviewers can copy-paste to verify. [Potential risks]: Address configuration concerns DetailsCurrent: "N/A" Recommended: Consider risks such as:
|
|
✅ PR description meets quality standards. The updated description successfully addresses all required sections:
|
What changed?
Adds an initial configuration for a
gitarpull request description reviewer.Why?
This reviewer is intended to recommend improvements to a pull request description to ensure it meets our planned standards for pull requests. The goal is to help contributors and maintainers upskill their descriptions, increasing the usefulness of pull requests for release notes, future and current contributors when reviewing code.
Gitar is currently under evaluation - though we will also consider evaluating GitHub copilot.
How did you test it?
Tested via integration tests in the GitHub repository (i.e it's running on this pull request and doing it successfully!).
Potential risks
This could become distracting, overly spammy, or increase overhead for contributors/maintainers during the code review process.
We will set up a follow up meeting to evaluate its effectiveness in contributing to pull request description quality.
Release notes
N/A
Documentation Changes
Documentation should be coming with the reviewers checklist PR https://github.com/cadence-workflow/cadence/pull/7596/changes.