Conversation
|
Hi. I think it would be much better to collect common properties of different cache types into a new type. then the new type can be embedded in each cache type so, the need to repeat all of them over and over again is eliminated. |
There was a problem hiding this comment.
Well done @RRostami . I opened two tiny discussions. There is also one good suggestion from @mmohamadi here which is considerable.
I also found one ambiguity in our readme regarding integrating Epimetheus which is better to be addressed explicitly.
This PR will be ready for merge after these modifications.
9f18a8f to
3f9e022
Compare
Reworked the CacheLayer files and made it an interface.
Added support for client-side hash sharding.
Added
redisclusterconfiguration which supports both sharding and Redis cluster.Moved internal contexts into a better place.
(Breaking Change: outward-facing TTL now requires a context as well)
Reworked internal configs (paving the way for more flexible input config on a later date)
Also added some config examples