Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt quoting to work in PowerShell 2 with targets containing a . #29

Closed
wants to merge 2 commits into from

Conversation

pascalberger
Copy link
Member

The current version of the bootstrapper fails while running in PowerShell 2 if a target containing a . in its name is passed (eg. .\build.ps1 -target foo.bar).

@gep13
Copy link
Member

gep13 commented May 3, 2017

Are changes required to the build.sh to support the same, or does it just work there?

@gep13
Copy link
Member

gep13 commented May 3, 2017

@pascalberger ^^

@pascalberger
Copy link
Member Author

@gep13 Unfortunately I don't have an environment at hand to test the build.sh. But I assume it is a PowerShell 2 specific quoting/escaping issue and therefore don't expect it to be an issue in the build.sh script

@gep13
Copy link
Member

gep13 commented May 3, 2017

@devlead am I right in saying that we have some integration tests running for the resources in this repository?

@devlead
Copy link
Member

devlead commented May 3, 2017

@gep13 Yes we execute using PowerShell current & v2 on AppVeyor and build.sh on Travis.

@gep13
Copy link
Member

gep13 commented May 4, 2017

@devlead are we in a position where we could add a check for a task with this in the name, and run on Travis with it?

@devlead
Copy link
Member

devlead commented May 4, 2017

@gep13 would likely just be a matter of changing this file in PR
https://github.com/cake-build/resources/blob/develop/.travis.yml

@pascalberger
Copy link
Member Author

@devlead Thanks! Will try to add testcases to the appveyor and travis configurations as part of this PR

@pascalberger pascalberger force-pushed the posh2support branch 4 times, most recently from 19abb24 to 9b7c699 Compare May 4, 2017 11:59
@pascalberger
Copy link
Member Author

@gep13 @devlead Added calls for current PowerShell, PowerShell v2 and the build.sh for calling a target containing a . to the build scripts (even though they won't necessarily break the build if they fail, but this is the same with other existing tests).

@pascalberger
Copy link
Member Author

pascalberger commented May 9, 2017

This should fix #20, but I saw that there is already an open PR cake-build/example#27 with a different approach.

@cake-build cake-build deleted a comment from dnfclas Dec 11, 2017
@gep13 gep13 closed this Nov 2, 2020
@gep13 gep13 deleted the branch cake-build:develop November 2, 2020 20:38
@pascalberger
Copy link
Member Author

We did some maintenance work on this repo which included removing of the develop branch which closed this PR.

This seems to be fixed based on cake-build/example#27 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants