-
-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adopt quoting to work in PowerShell 2 with targets containing a . #29
Conversation
Are changes required to the build.sh to support the same, or does it just work there? |
@gep13 Unfortunately I don't have an environment at hand to test the build.sh. But I assume it is a PowerShell 2 specific quoting/escaping issue and therefore don't expect it to be an issue in the build.sh script |
@devlead am I right in saying that we have some integration tests running for the resources in this repository? |
@gep13 Yes we execute using PowerShell current & v2 on AppVeyor and build.sh on Travis. |
@devlead are we in a position where we could add a check for a task with this in the name, and run on Travis with it? |
@gep13 would likely just be a matter of changing this file in PR |
@devlead Thanks! Will try to add testcases to the appveyor and travis configurations as part of this PR |
19abb24
to
9b7c699
Compare
This should fix #20, but I saw that there is already an open PR cake-build/example#27 with a different approach. |
We did some maintenance work on this repo which included removing of the This seems to be fixed based on cake-build/example#27 (comment). |
The current version of the bootstrapper fails while running in PowerShell 2 if a target containing a
.
in its name is passed (eg..\build.ps1 -target foo.bar
).