-
Notifications
You must be signed in to change notification settings - Fork 106
Deprecate identifier collection approach. #712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Mark Story <[email protected]>
Added also a test for a direct IdentifierCollection passed: |
There's |
Good point. |
Are we good to continue here? |
Co-authored-by: Mark Story <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding that configuration test. There are a few more errors in the docs.
Co-authored-by: Mark Story <[email protected]>
Co-authored-by: Mark Story <[email protected]>
Co-authored-by: Mark Story <[email protected]>
Co-authored-by: Mark Story <[email protected]>
Co-authored-by: Mark Story <[email protected]>
Co-authored-by: Mark Story <[email protected]>
Co-authored-by: Mark Story <[email protected]>
Co-authored-by: Mark Story <[email protected]>
Co-authored-by: Mark Story <[email protected]>
Co-authored-by: Mark Story <[email protected]>
Co-authored-by: Mark Story <[email protected]>
We should definitly squash merge this one 🗡️ |
Is this going into 3.x or 3.next? |
Refs #710
The config has to be only slightly adjusted to be "safer".
Seems BC and easy to switch up.