Skip to content

Deprecate identifier collection approach. #712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Apr 30, 2025

Conversation

dereuromark
Copy link
Member

Refs #710

The config has to be only slightly adjusted to be "safer".
Seems BC and easy to switch up.

@dereuromark dereuromark added this to the 3.next milestone Apr 20, 2025
@dereuromark dereuromark marked this pull request as ready for review April 20, 2025 11:33
@dereuromark
Copy link
Member Author

Added also a test for a direct IdentifierCollection passed:
f2c713e
Or is that also deprecated? I guess it can be useful in some rare cases.

@dereuromark dereuromark mentioned this pull request Apr 20, 2025
3 tasks
@ADmad
Copy link
Member

ADmad commented Apr 22, 2025

There's AuthenticationService::getIdentificationProvider() which returns the identifier instance which successfully returned the identity. So that method needs to be updated too to get the identifier instance from the successful authenticator (if the IdentifierCollection::getIdentificationProvider() instance for the AuthenticationServices returns null).

@dereuromark
Copy link
Member Author

Good point.
Done :)

@dereuromark dereuromark requested a review from markstory April 23, 2025 14:02
@dereuromark
Copy link
Member Author

Are we good to continue here?

Copy link
Member

@markstory markstory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding that configuration test. There are a few more errors in the docs.

@dereuromark
Copy link
Member Author

We should definitly squash merge this one 🗡️

@dereuromark
Copy link
Member Author

dereuromark commented Apr 29, 2025

Is this going into 3.x or 3.next?

@dereuromark dereuromark changed the base branch from 3.x to 3.next April 30, 2025 10:49
@dereuromark dereuromark merged commit 6a7a8d6 into 3.next Apr 30, 2025
6 of 8 checks passed
@dereuromark dereuromark deleted the deprecate-identifier-collection branch April 30, 2025 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants