Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more files to gitattributes export-ignore #1216

Merged
merged 1 commit into from
Oct 16, 2017

Conversation

ntzm
Copy link
Contributor

@ntzm ntzm commented Oct 16, 2017

This might be a bit too strict for you, but it's what seems to be non-essential for package installation.

(Sorry for spamming PRs, let me know if you want me to stop 😛)

@dereuromark
Copy link
Member

dereuromark commented Oct 16, 2017

The Changelog and Upgrade files at least should probably stay.

@codecov-io
Copy link

codecov-io commented Oct 16, 2017

Codecov Report

Merging #1216 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1216   +/-   ##
======================================
  Coverage    72.2%   72.2%           
======================================
  Files          35      35           
  Lines        5580    5580           
======================================
  Hits         4029    4029           
  Misses       1551    1551

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e48e0a...cd3b092. Read the comment docs.

@ntzm ntzm force-pushed the update-export-ignores branch from cd3b092 to 059caaf Compare October 16, 2017 21:45
@ntzm
Copy link
Contributor Author

ntzm commented Oct 16, 2017

Wasn't sure about those files, thanks for clarifying :) Updated

@dereuromark dereuromark merged commit 3fa84c8 into cakephp:master Oct 16, 2017
@ntzm ntzm deleted the update-export-ignores branch October 16, 2017 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants