Skip to content

Conversation

charlie-costanzo
Copy link
Member

@charlie-costanzo charlie-costanzo commented Sep 5, 2025

Description

Create new dag task for external table creation of new NTD API ridership table

Resolves #4208

Type of change

  • New feature

How has this been tested?

local airflow
Screenshot 2025-09-08 at 10 31 28

Post-merge follow-ups

  • Actions required (specified below)
    make sure it runs in production, create warehouse tables

@charlie-costanzo charlie-costanzo self-assigned this Sep 5, 2025
@charlie-costanzo charlie-costanzo added the data-pipeline-ingestion-and-modeling Ingesting, parsing and modeling data. Evan Siroky is product owner. label Sep 5, 2025
@charlie-costanzo charlie-costanzo force-pushed the ntd-ridership-api-endpoint-external-tables branch from 0a50bc7 to 0dcc714 Compare September 5, 2025 21:54
Copy link

github-actions bot commented Sep 5, 2025

Terraform plan in iac/cal-itp-data-infra/airflow/us

Plan: 1 to add, 0 to change, 0 to destroy.
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
+   create

Terraform will perform the following actions:

  # google_storage_bucket_object.calitp-composer["dags/create_external_tables/ntd_data_products/historical__complete_monthly_ridership_with_adjustments_and_estimates.yml"] will be created
+   resource "google_storage_bucket_object" "calitp-composer" {
+       bucket         = "calitp-composer"
+       content        = (sensitive value)
+       content_type   = (known after apply)
+       crc32c         = (known after apply)
+       detect_md5hash = "different hash"
+       generation     = (known after apply)
+       id             = (known after apply)
+       kms_key_name   = (known after apply)
+       md5hash        = (known after apply)
+       md5hexhash     = (known after apply)
+       media_link     = (known after apply)
+       name           = "dags/create_external_tables/ntd_data_products/historical__complete_monthly_ridership_with_adjustments_and_estimates.yml"
+       output_name    = (known after apply)
+       self_link      = (known after apply)
+       source         = "../../../../airflow/dags/create_external_tables/ntd_data_products/historical__complete_monthly_ridership_with_adjustments_and_estimates.yml"
+       storage_class  = (known after apply)
    }

Plan: 1 to add, 0 to change, 0 to destroy.

📝 Plan generated in Plan Terraform for Warehouse and DAG changes #578

Copy link

github-actions bot commented Sep 5, 2025

Terraform plan in iac/cal-itp-data-infra-staging/airflow/us

Plan: 1 to add, 0 to change, 0 to destroy.
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
+   create

Terraform will perform the following actions:

  # google_storage_bucket_object.calitp-staging-composer["dags/create_external_tables/ntd_data_products/historical__complete_monthly_ridership_with_adjustments_and_estimates.yml"] will be created
+   resource "google_storage_bucket_object" "calitp-staging-composer" {
+       bucket         = "calitp-staging-composer"
+       content        = (sensitive value)
+       content_type   = (known after apply)
+       crc32c         = (known after apply)
+       detect_md5hash = "different hash"
+       generation     = (known after apply)
+       id             = (known after apply)
+       kms_key_name   = (known after apply)
+       md5hash        = (known after apply)
+       md5hexhash     = (known after apply)
+       media_link     = (known after apply)
+       name           = "dags/create_external_tables/ntd_data_products/historical__complete_monthly_ridership_with_adjustments_and_estimates.yml"
+       output_name    = (known after apply)
+       self_link      = (known after apply)
+       source         = "../../../../airflow/dags/create_external_tables/ntd_data_products/historical__complete_monthly_ridership_with_adjustments_and_estimates.yml"
+       storage_class  = (known after apply)
    }

Plan: 1 to add, 0 to change, 0 to destroy.

📝 Plan generated in Plan Terraform for Warehouse and DAG changes #578

@charlie-costanzo charlie-costanzo marked this pull request as ready for review September 8, 2025 14:47
@charlie-costanzo charlie-costanzo force-pushed the ntd-ridership-api-endpoint-external-tables branch from eb767d4 to 0e3e223 Compare September 9, 2025 13:59
@charlie-costanzo charlie-costanzo force-pushed the ntd-ridership-api-endpoint-external-tables branch from 0e3e223 to 3dd4c7a Compare September 9, 2025 17:35
@charlie-costanzo charlie-costanzo merged commit aa87b03 into main Sep 9, 2025
7 checks passed
@charlie-costanzo charlie-costanzo deleted the ntd-ridership-api-endpoint-external-tables branch September 9, 2025 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data-pipeline-ingestion-and-modeling Ingesting, parsing and modeling data. Evan Siroky is product owner.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

We should reassess and move scraping for some ntd files from the xlsx pipeline to the api
2 participants