Fix corruption server demos #433
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Caball009
commented
Jul 8, 2024
|
|
||
| client->unksnapshotvar = 1; | ||
| // if the client is up-to-date, or the demo has been waiting for PACKET_BACKUP (32) or more snapshots, start the demo with a non-delta snapshot | ||
| if (client->netchan.outgoingSequence - client->deltaMessage == 1 || client->netchan.outgoingSequence - client->demoRequestedSequence >= PACKET_BACKUP) |
There was a problem hiding this comment.
client->netchan.outgoingSequence - client->deltaMessage == 1
I've no idea if this works correctly, but the idea is to find some logic that limits the maximum number of non-delta snapshots / frames to the absolute minimum, just one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's currently possible for server demos to get corrupted. This happens when delta snapshots rely on data from older snapshots that are not included in the demo.
This is currently untested hence a draft pr. This problem has previously been mentioned in #394 220e324 but not yet fixed.