fix: fix crash when change tab bar label during runtime#250
Merged
okwasniewski merged 3 commits intocallstack:mainfrom Jan 21, 2025
Merged
fix: fix crash when change tab bar label during runtime#250okwasniewski merged 3 commits intocallstack:mainfrom
okwasniewski merged 3 commits intocallstack:mainfrom
Conversation
owinter86
force-pushed
the
tabLabelFix
branch
from
c2439ee to
e59a50f
Compare
okwasniewski
approved these changes
Jan 21, 2025
Collaborator
okwasniewski
left a comment
okwasniewski
left a comment
There was a problem hiding this comment.
Thanks for fixing this! 🎉
packages/react-native-bottom-tabs/android/src/main/java/com/rcttabview/RCTTabView.kt
Outdated
Show resolved
Hide resolved
packages/react-native-bottom-tabs/android/src/main/java/com/rcttabview/RCTTabView.kt
Outdated
Show resolved
Hide resolved
|
Thanks for the quick PR. Can confirm it works fine now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
This fixes the issue where android will crash when changing the tab bar label during run time crashes the app.
Fixes #248
How to test?
I have added a state change in the longPress event within the NativeBottomTabs example, this should change the first tab from "Article" to "CHANGED".