feat: initial poc #1020
Draft
feat: initial poc #1020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
troZee
reviewed
Aug 20, 2025
gtokman
reviewed
Aug 20, 2025
gtokman
reviewed
Aug 20, 2025
gtokman
reviewed
Aug 20, 2025
gtokman
reviewed
Aug 20, 2025
okwasniewski
force-pushed
the
feat/swiftui
branch
5 times, most recently
from
0dbfd17 to
9086068
Compare
krozniata
reviewed
Aug 21, 2025
krozniata
reviewed
Aug 21, 2025
okwasniewski
force-pushed
the
feat/swiftui
branch
4 times, most recently
from
1b89f44 to
adc64b1
Compare
okwasniewski
force-pushed
the
feat/swiftui
branch
from
adc64b1 to
e5b3f1c
Compare
krozniata
reviewed
Aug 28, 2025
| @@ -10,7 +10,7 @@ export const childrenWithOverriddenStyle = (children?: ReactNode) => { | |||
| {React.cloneElement(element, { | |||
| ...element.props, | |||
| // Override styles so that each page will fill the parent. | |||
| style: [element.props.style, StyleSheet.absoluteFill], | |||
| style: [element.props.style, { width: '100%', height: '100%' }], | |||
There was a problem hiding this comment.
Why was this change required? Won't it affect rendering child on Android?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan
What's required for testing (prerequisites)?
What are the steps to reproduce (after prerequisites)?
Compatibility
Checklist
README.md