-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
fix: fixing MaterialBottomTabNavigator issues #4615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Hey @RainPlays09, thank you for your pull request 🤗. The documentation from this branch can be viewed here. |
@BogiKay Could you review my PR?? |
Hey @RainPlays09, sorry for the delay. I checked your PR and when it comes to the types it looks fine. My only concern is that If you update react-navigation to v7 in the example app and run web app, then you'll get an error Something like example below should fix the problem. I didn't test it yet, just wanted to visualise what can be done to fix v7 in web apps and to provide temporarily backward compatibility for users that haven't yet migrated to v7.
Share your thoughts on it and let me know if I can help you. |
Hello @BogiKay, I'm sorry to any unattended action regarding this PR, I'm still learning regarding git commands. So I try your suggestion regarding the |
Motivation
I created this PR to fix some issue regarding the MaterialBottomNavigation like Fixing the createMaterialBottomTabNavigator types based on react-navigation@7 because the code is outdated to the example of react-navigation.