Fix the step resolution calculation for StepMarker and steps when default settings #636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
draggie
reviewed
Sep 18, 2024
| export const constants = { | ||
| MARGIN_HORIZONTAL_PADDING: 0.05, | ||
| STEP_NUMBER_TEXT_FONT_SMALL: 8, | ||
| STEP_NUMBER_TEXT_FONT_BIG: 12, | ||
| LIMIT_MIN_VALUE: Number.MIN_SAFE_INTEGER, | ||
| LIMIT_MAX_VALUE: Number.MAX_SAFE_INTEGER, | ||
| DEFAULT_STEP_RESOLUTION: 100, | ||
| DEFAULT_STEP_RESOLUTION: Platform.OS === 'android' ? 128 : 1000, |
There was a problem hiding this comment.
shouldn't this be 100 not 1000 ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes #606
It applies the fix found during the review of #581
The fix separates the meaning of
stepfrom the resolution of step(s) when calculating the layout of theStepMarkerscenario render.