React 19 fixes #705
Open
React 19 fixes #705
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes #701
Fixes #695
defaultPropsandfindDOMNodewere removed in React 19.For
findDOMNode: it wasn't actually needed, as the ref is already pointed at the element. I addeddomto the TS libs to support the type, but we can use a ts-ignore if you don't want that.For
defaultProps: I moved the values to default parameters in the function component and cleaned up the logic someTest Plan:
example-webis updated to react 19 and fully working now.I haven't gotten a chance to test this on native yet