Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: named capturing groups #65

Closed
wants to merge 1 commit into from
Closed

Conversation

mdjastrzebski
Copy link
Member

@mdjastrzebski mdjastrzebski commented Feb 20, 2024

Summary

Implement named capturing groups.

API

capture('abc', { name: 'xyz' });

Test plan

Added relevant tests.

  • Implementation
  • Test coverage for pattern and behavior
  • API docs
  • README docs (optional)
  • Example docs & tests

@codecov-commenter
Copy link

codecov-commenter commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (1674ace) to head (e03e707).

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #65   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           14        14           
  Lines          165       168    +3     
  Branches        39        40    +1     
=========================================
+ Hits           165       168    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mdjastrzebski mdjastrzebski marked this pull request as draft February 20, 2024 21:20
@mdjastrzebski mdjastrzebski marked this pull request as ready for review February 28, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants