-
Notifications
You must be signed in to change notification settings - Fork 226
docs(migration-tooling): code conversion: update / move docs from repo #7472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
versioned_docs/version-8.8/guides/migrating-from-camunda-7/code-conversion.md
Outdated
Show resolved
Hide resolved
c196449 to
06f8a37
Compare
4412677 to
e384b1d
Compare
e384b1d to
51b610f
Compare
|
@venetrius please add the relevant labels so we can triage - is this for an alpha or the 8.9 minor for example? 🙏 |
|
@mesellings |
Thanks @venetrius I assume you mean alpha-2, not alpha-1? 😊 As the release is on Tuesday, this can probably be merged and released today/tomorrow 👍 |
@mesellings Yes, correct! Thanks! |
HeleneW-dot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm!
|
|
||
| The complete pattern catalog with code examples is maintained on GitHub: | ||
|
|
||
| **[Browse the pattern catalog →](https://github.com/camunda/camunda-7-to-8-migration-tooling/tree/main/code-conversion/patterns)** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the little arrow intended?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 I removed the little arrow
| | **Cleanup** | AllClientCleanupRecipes | AllDelegateCleanupRecipes | AllExternalWorkerCleanupRecipes | | ||
| | **Combined** | AllClientRecipes | AllDelegateRecipes | AllExternalWorkerRecipes | | ||
|
|
||
| You can apply recipes individually by phase, or use the **Combined** recipes to run all three phases at once. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Unsure about capitalisation here
| You can apply recipes individually by phase, or use the **Combined** recipes to run all three phases at once. | |
| You can apply recipes individually by phase, or use the **combined** recipes to run all three phases at once. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 I updated it in both latest and 8.8
giorgionaps
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TW edits completed from my side, all corrections committed directly to the branch
giorgionaps
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-approving after deleting emojis
|
@venetrius does this need publishing for the alpha-2 release tomorrow? |
Yes, merged it now. |
|
Thanks for the reviews! |
related to: camunda/camunda-7-to-8-migration-tooling/issues/415
Description
When should this change go live?
bugorsupportlabel)available & undocumentedlabel)holdlabel)low priolabel)PR Checklist
{type}(scope): {description}commit message(s)/docsdirectory (version 8.9)./versioned_docsdirectory.@camunda/tech-writersunless working with an embedded writer.