-
Notifications
You must be signed in to change notification settings - Fork 226
fix: elasticsearch in HC is disabled by default #7477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Jesse Simpson <[email protected]>
|
👋 🤖 🤔 Hello, @mesellings! Did you make your changes in all the right places? These files were changed only in docs/. You might want to duplicate these changes in versioned_docs/version-8.8/.
You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines. |
mesellings
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm @jessesimpson36 I made a few edits around rewording and moving it to the top as a breaking change - does this need to be held back until alpha-2 has been released, or can it go out now?
|
@mesellings I don't think we need to wait for after alpha2 for this docs update as it only affects 8.9, but we are only planning on merging the helm-chart change after alpha2 is already released. Worst case scenario, someone gets a little confused testing an alpha and asks us in ask-self-managed and I answer. No harm in merging / deploying this early. |
Thanks @jessesimpson36 we might as well hold it back now for a few days, then push it 👍 |
Description
One of the decisions made as part of the Liquibase epic and the RDBMS epic is that we no longer want people to view Elasticsearch as the preferred method of installing the helm chart. We want to present it as one of 3 valid options. In support of that idea, this PR goes through all of the code snippets related to using elasticsearch, and inserts the options
global.elasticsearch.enabled=trueandelasticsearch.enabled=trueso that those snippets will be functional after this change.I also included an announcement explaining the change.
Task disabling elasticsearch in HC by default:
camunda/camunda-platform-helm#4671
Liquibase epic: https://github.com/camunda/product-hub/issues/3023
RDBMS epic: https://github.com/camunda/product-hub/issues/2690
Alternative infrastructure services: https://github.com/camunda/product-hub/issues/3098
(relevant from this line)
And related to this: #7317
When should this change go live?
bugorsupportlabel)available & undocumentedlabel)holdlabel)low priolabel)PR Checklist
{type}(scope): {description}commit message(s)/docsdirectory (version 8.9)./versioned_docsdirectory.@camunda/tech-writersunless working with an embedded writer.