fix(irc): stop background exchange poll loop on session dispose#809
Open
apoc wants to merge 1 commit intocan1357:mainfrom
Open
fix(irc): stop background exchange poll loop on session dispose#809apoc wants to merge 1 commit intocan1357:mainfrom
apoc wants to merge 1 commit intocan1357:mainfrom
Conversation
The 50ms retry loop in #scheduleBackgroundExchangeFlush had no guard against session teardown. If dispose() was called while streaming, the setTimeout callbacks kept firing and attempted emitExternalEvent on a disconnected agent. - Add #isDisposed flag; set it at the top of dispose() before any async teardown so poll ticks that fire mid-teardown bail out cleanly - Clear #pendingBackgroundExchanges in dispose() to drop queued messages that will never be rendered - Widen the attempt() bail condition to include #isDisposed so the loop terminates even if new messages arrived between the dispose() clear and the next tick
apoc
force-pushed
the
fix/irc-poll-teardown-guard
branch
from
e52485f to
905b8e6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 50ms retry loop in
#scheduleBackgroundExchangeFlushhad no guard against session teardown. Ifdispose()was called while streaming, thesetTimeoutcallbacks kept firing and attemptedemitExternalEventon a disconnected agent indefinitely.Changes
#isDisposedflag; set it synchronously at the top ofdispose()before any async teardown so poll ticks that fire mid-teardown bail out cleanly#pendingBackgroundExchangesindispose()to drop queued messages that will never be renderedattempt()bail condition to include#isDisposedso the loop terminates even if new messages arrived between thedispose()clear and the next tick (small window during async teardown)