Split session reload semantics#835
Open
HabibPro1999 wants to merge 1 commit intocan1357:mainfrom
Open
Conversation
HabibPro1999
force-pushed
the
feat/reload-semantics
branch
from
4ad6738 to
3e5ce7e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
AgentSession.reloadSessionFile()for current session-file reload semantics.AgentSession.reloadRuntimeResources()as the separated future runtime-resource reload API placeholder.AgentSession.reload()as a deprecated alias to session-file reload.Why
OMP currently uses
reload()for session-file reloads, while Pi-style/reloadmeans runtime resources/config/extensions/tools. This PR separates those concepts before implementing global runtime reload behavior.Part of the Pi runtime/agentic harness migration stack.
Testing
bun test packages/coding-agent/test/agent-session-openai-responses-replay.test.ts packages/coding-agent/test/sdk-session-isolation.test.tsbunx biome checkon all files changed by this PRbun run check:tsandPATH="$HOME/.cargo/bin:$PATH" bun run checkKnown caveat after rebasing onto latest
main: fullbun run check:tsis currently blocked by unrelated Biome formatting/import-order issues already present inorigin/mainfiles not touched by this PR (line-hash.ts,tools/renderers.ts,tools.test.ts,tools/search-renderer.test.ts).bun checkpasses (blocked after latestmainrebase by unrelated upstream Biome issues listed above)