fix(xdg): resolve marketplace plugins path when using xdg spec #885
Closed
Parsifa1 wants to merge 1 commit intocan1357:mainfrom
Closed
fix(xdg): resolve marketplace plugins path when using xdg spec #885Parsifa1 wants to merge 1 commit intocan1357:mainfrom
marketplace plugins path when using xdg spec #885Parsifa1 wants to merge 1 commit intocan1357:mainfrom
Conversation
Parsifa1
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fd4331a9e0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Parsifa1
force-pushed
the
fix/xdg-plugin-discovery
branch
from
fd4331a to
c6913d0
Compare
Contributor
Author
Parsifa1
force-pushed
the
fix/xdg-plugin-discovery
branch
2 times, most recently
from
fe0df46 to
0a4b407
Compare
Parsifa1
changed the title
marketplace plugins when using xdg spec
Parsifa1
changed the title
marketplace plugins when using xdg spec marketplace plugins path when using xdg spec
Parsifa1
force-pushed
the
fix/xdg-plugin-discovery
branch
from
0a4b407 to
ce66ae3
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
listClaudePluginRoots()was always reading the OMP user plugin registry from the legacy home-relative path (~/.omp/plugins/installed_plugins.jsonor~/.config/omp/...depending ongetConfigDirName()). On XDG-enabled systems the marketplace writes the registry to$XDG_DATA_HOME/omp/plugins/installed_plugins.json, so the paths never matched and marketplace-installed skills were silently ignored at discovery time.now we using
resolveUserPluginsDir()to resolve user plugins, and also resolve xdg spec.Why
Marketplace-installed skills were not loaded after installation on any system with
XDG_DATA_HOMEset. The install wrote to the XDG path; discovery always read from the legacy path.Test
bun checkpassesall same as #707, but fix the test, able to merge :)
mainly fixed the
/marketplaceplugins resolved for xdg plugin discovery