fix extension dashboard toggles#921
Open
tycronk20 wants to merge 1 commit intocan1357:mainfrom
Open
Conversation
a538fa1 to
a49d19c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The extension toggle bug was caused by the dashboard persisting the new disabledExtensions setting but continuing to render from the previously loaded dashboard state until the async capability refresh completed. Pressing Space could briefly make the selected extension look disabled, but navigating the list, switching providers, or closing and reopening the panel rebuilt the UI from stale extension objects that still had state: "active", so the indicator flipped back to green even though the setting had changed. This fix applies the updated disabled-extension set to the in-memory dashboard state immediately, then still runs the full capability refresh afterward so provider state, shadowing, and discovery results remain accurate. It also guards against stale async refresh completions and requests a render once refreshes finish, keeping the toggle state stable across navigation and panel reopen.