[v3] [Proposal] Bring prettier to the v3 #1545
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peaBerberian
added
proposal
peaBerberian
force-pushed
the
misc/prettierv3
branch
from
605dc27
to
f320bb6
Compare
|
Some files are not correctly formatted according to the CI |
|
Yes, see note on top of the PR's message |
One of the bigger pain points of backporting fixes and improvements to the v3 is due to the fact that we rely on prettier for the v4 but not on the v3, leading to huge conflicts in the end mostly related to different formatting. This PR proposes that we bring prettier and a similar eslint config to the v3 just to ease comparisons between both major versions. Note that some eslint rules enabled on the v4 are here not enabled, mostly `eqeqeq` and `no-nested-ternaries`(both because that's a lot of work). For that second rule, the fact that we also run prettier may lead to code harder to read than before.
peaBerberian
force-pushed
the
misc/prettierv3
branch
from
f320bb6
to
8ab56ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: I did not run prettier yet, only eslint with fixes enabled. This is because we're still waiting for #1544 to be merged
One of the bigger pain points of backporting fixes and improvements to the v3 is due to the fact that we rely on prettier for the v4 but not on the v3, leading to huge conflicts in the end mostly related to different formatting.
This PR proposes that we bring prettier and a similar eslint config to the v3 just to ease comparisons between both major versions.
Note that some eslint rules enabled on the v4 are here not enabled, mostly
eqeqeqandno-nested-ternaries(both because that's a lot of work).For that second rule, the fact that we also run prettier may lead to code harder to read than before.
I also profited from this to better align CI checks between the two majors.