feature: add the possibility to rely on managedMediaSource on iOS devices #1562

Florent-Bouisset · 2024-10-03T09:42:13Z

Add the possibility to rely on ManagedMediaSource for devices that has no access to MediaSource such as iOS devices with version > 17.1

In practice that allow devices like iPhone to play DASH content with the RxPlayer.

Note that it is not possible to cast a DASH content with AirPlay, so the RxPlayer disable the possibility to stream to AirPlay by adding the disableRemotePlayback attribute to the video Element when a DASH content is loaded.

#1294

src/main_thread/init/multi_thread_content_initializer.ts

src/main_thread/init/utils/create_media_source.ts

peaBerberian · 2024-10-03T12:25:52Z

Aren't there also supplementary events we're supposed to handle as a player with a ManagedMediaSource?
To me that was one of the arguments for it.

I know there's the potentiality of GC at any time, which I think we prefer and already support, and that brings the bufferedchange event which we could use but nothing urgent for that one.
But there's also mainly the stopStreaming / startStreaming events on which we're supposed to pause / resume our [adequately named] stream logic (the loading and pushing segments operations), no?

src/compat/browser_compatibility_types.ts

src/core/fetchers/segment/segment_queue.ts

src/core/stream/representation/representation_stream.ts

peaBerberian · 2024-10-22T13:55:41Z

So if I get it, we will not be reacting to startstreaming/endstreaming directly but we'll just check mediaSource.streaming in the next playback observation.

I wonder if it's what we want:

For endstreaming, it depends on the philosophy of the event. I'm not sure of what is wanted from us here by reading the spec.
For startstreaming, it depends on what the user-agent defined as its [cannot] play uninterrupted and efficiently limit...

peaBerberian · 2024-10-22T13:56:43Z

We could also have a supplementary parameter streamingReference everywhere but I understand that it is less nice than having it in a playback observation

src/main_thread/init/utils/create_core_playback_observer.ts

peaBerberian · 2024-10-31T13:46:59Z

src/experimental/tools/VideoThumbnailLoader/prepare_source_buffer.ts

+         */
+        if (
+          "disableRemotePlayback" in videoElement &&
+          disableRemotePlaybackPreviousValue !== undefined


Why having that condition?

first condition "disableRemotePlayback" in videoElement because on browsers that does not have disableRemotePlayback I don't see the point of setting it.

2nd condition disableRemotePlaybackPreviousValue !== undefined is because typescript don't allow to possibly assign videoElement.disableRemotePlayback to undefined. Because it's typed as disableRemote?: boolean

It was for the second condition.

So it creates a weird situation where we would reset the value UNLESS it was previously set to undefined...

Maybe calling something like removeAttribute in that case is more logical / simpler to understand?

UNLESS it was previously set to undefined

The property is a boolean so it should never be set to undefined

I can use removeAttribute but this will not reset it to true if that was already true before using the RxPlayer

Florent-Bouisset · 2024-10-31T13:49:49Z

So if I get it, we will not be reacting to startstreaming/endstreaming directly but we'll just check mediaSource.streaming in the next playback observation.

I wonder if it's what we want:

For endstreaming, it depends on the philosophy of the event. I'm not sure of what is wanted from us here by reading the spec.

For startstreaming, it depends on what the user-agent defined as its [cannot] play uninterrupted and efficiently limit...

Don't know if the comment is outdated, but it actually send an event streamingChanged and the playbackObserver emit a new observation on the "endstreaming" and "startstreaming" event.
The value is passed down to the representationStream and to the segmentQueue. The next time a segment is intended to be loaded the segmentQueue it check the value on the last observation, so It should be OK.

src/core/fetchers/segment/segment_queue.ts

src/core/stream/representation/representation_stream.ts

src/main_thread/init/utils/create_core_playback_observer.ts

…ices add unit test for managed media source handle start and end stream event from managedMediaSource fix unit test react to event endStreaming and startStreaming to immediately trigger a new observation and to download the segments sooner review feedback restart Loading queue if it canLoad is updated add clearSignal to prevent memory leak remove undefined from canLoad only set disableRemotePlayback if it's defined by the browser fmt

peaBerberian · 2024-11-08T11:08:33Z

src/experimental/tools/VideoThumbnailLoader/prepare_source_buffer.ts

+         * in order to leave the <video> element in the same state has it was set
+         * by the application before calling the RxPlayer.
+         */
+        if (disableRemotePlaybackPreviousValue !== undefined) {


I thought that if videoElement.disableRemotePlayback was defined, it was always a boolean. We already checked that "disableRemotePlayback" in videoElement, so how come disableRemotePlaybackPreviousValue can now be set to undefined for TypeScript?

peaBerberian · 2024-11-08T11:09:38Z

src/main_thread/init/multi_thread_content_initializer.ts

+                 * an Airplay source alternative, such as HLS.
+                 * https://github.com/w3c/media-source/issues/320
+                 */
+                mediaElement.disableRemotePlayback = true;


We could also put that one inside a if like in the other place no?

peaBerberian · 2024-11-08T11:11:31Z

src/main_thread/init/multi_thread_content_initializer.ts

+                 * an Airplay source alternative, such as HLS.
+                 * https://github.com/w3c/media-source/issues/320
+                 */
+                mediaElement.disableRemotePlayback = true;


Is it possible to just factorize all places where we doing this as it looks fairly similar?

I see the factorized code but why isn't it used here?

Yes I have replaced it once it that file but it was actually used twice, thanks will update it

peaBerberian · 2024-11-12T11:16:28Z

src/main_thread/init/utils/create_media_source.ts

+  mediaElement: IMediaElement,
+  cancellationSignal: CancellationSignal,
+) {
+  if (isManagedMediaSource && "disableRemotePlayback" in mediaElement) {


It's a weird combination when I read this to:

have a method just called disableRemotePlayback that takes a media element and a cancel signal (which I would assume just disable remote playback until the cancel signal emits I guess)

have it inside create_media_source.ts and have it checking isManagedMediaSource (and doing nothing if that isn't the case)

Yes but the other way around I would need to repeat the condition
if (isManagedMediaSource && "disableRemotePlayback" in mediaElement) every time disableRemotePlayback() is used. I found it to be more factorized like that, do you prefer the other way and repeat the condition?

Or maybe I could rename it so it is more clear that it could disable it or not depending of the type of mediaSource

peaBerberian reviewed Oct 3, 2024

View reviewed changes

src/main_thread/init/multi_thread_content_initializer.ts Show resolved Hide resolved

peaBerberian reviewed Oct 3, 2024

View reviewed changes

src/main_thread/init/utils/create_media_source.ts Outdated Show resolved Hide resolved

peaBerberian added this to the 4.3.0 milestone Oct 4, 2024

Florent-Bouisset force-pushed the feature/add-managed-media-source branch from 27776f2 to a6b5a49 Compare October 22, 2024 10:19

peaBerberian reviewed Oct 22, 2024

View reviewed changes

src/compat/browser_compatibility_types.ts Outdated Show resolved Hide resolved

peaBerberian reviewed Oct 22, 2024

View reviewed changes

src/core/fetchers/segment/segment_queue.ts Outdated Show resolved Hide resolved

peaBerberian reviewed Oct 22, 2024

View reviewed changes

src/core/fetchers/segment/segment_queue.ts Outdated Show resolved Hide resolved

peaBerberian reviewed Oct 22, 2024

View reviewed changes

src/core/stream/representation/representation_stream.ts Outdated Show resolved Hide resolved

peaBerberian reviewed Oct 25, 2024

View reviewed changes

src/main_thread/init/utils/create_core_playback_observer.ts Outdated Show resolved Hide resolved

Florent-Bouisset force-pushed the feature/add-managed-media-source branch 2 times, most recently from babacfe to 2fd5e0c Compare October 31, 2024 13:41

peaBerberian reviewed Oct 31, 2024

View reviewed changes

peaBerberian reviewed Nov 5, 2024

View reviewed changes

src/core/fetchers/segment/segment_queue.ts Outdated Show resolved Hide resolved

peaBerberian reviewed Nov 5, 2024

View reviewed changes

src/core/stream/representation/representation_stream.ts Outdated Show resolved Hide resolved

peaBerberian reviewed Nov 5, 2024

View reviewed changes

src/main_thread/init/utils/create_core_playback_observer.ts Outdated Show resolved Hide resolved

Florent-Bouisset force-pushed the feature/add-managed-media-source branch from 6571e83 to 90e74cc Compare November 7, 2024 09:20

peaBerberian reviewed Nov 8, 2024

View reviewed changes

factorize

1435b6f

peaBerberian reviewed Nov 12, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feature: add the possibility to rely on managedMediaSource on iOS devices #1562

feature: add the possibility to rely on managedMediaSource on iOS devices #1562

Florent-Bouisset commented Oct 3, 2024

peaBerberian commented Oct 3, 2024 •

edited

Loading

peaBerberian commented Oct 22, 2024

peaBerberian commented Oct 22, 2024

peaBerberian Oct 31, 2024

Florent-Bouisset Oct 31, 2024

peaBerberian Nov 5, 2024

Florent-Bouisset Nov 6, 2024

Florent-Bouisset commented Oct 31, 2024

peaBerberian Nov 8, 2024

Florent-Bouisset Nov 8, 2024

peaBerberian Nov 8, 2024

peaBerberian Nov 8, 2024

Florent-Bouisset Nov 8, 2024

peaBerberian Nov 12, 2024

Florent-Bouisset Nov 12, 2024

peaBerberian Nov 12, 2024 •

edited

Loading

Florent-Bouisset Nov 12, 2024

Florent-Bouisset Nov 12, 2024

feature: add the possibility to rely on managedMediaSource on iOS devices #1562

Are you sure you want to change the base?

feature: add the possibility to rely on managedMediaSource on iOS devices #1562

Conversation

Florent-Bouisset commented Oct 3, 2024

peaBerberian commented Oct 3, 2024 • edited Loading

peaBerberian commented Oct 22, 2024

peaBerberian commented Oct 22, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Florent-Bouisset commented Oct 31, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

peaBerberian Nov 12, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

peaBerberian commented Oct 3, 2024 •

edited

Loading

peaBerberian Nov 12, 2024 •

edited

Loading