chore: update charm definitions to support Juju 4.0#2231
Open
Ninfa-Jeon wants to merge 5 commits intocanonical:mainfrom
Open
chore: update charm definitions to support Juju 4.0#2231Ninfa-Jeon wants to merge 5 commits intocanonical:mainfrom
Ninfa-Jeon wants to merge 5 commits intocanonical:mainfrom
Conversation
Ninfa-Jeon
added
Review: QA needed
Review: Code needed
e2e
Demo
Jenkins 
demos.haus
Ninfa-Jeon
force-pushed
the
update-charmdef-juju4
branch
5 times, most recently
from
edaa9fe to
6cd149a
Compare
Coverage Report
File CoverageNo changed files found. |
Ninfa-Jeon
force-pushed
the
update-charmdef-juju4
branch
from
6cd149a to
52cd528
Compare
huwshimi
reviewed
Feb 24, 2026
| timeout_minutes: 1 | ||
| max_attempts: 5 # Retry the wait-for with a short timeout in case it gets stuck and times out. If it fails after multiple tries it's probably a real error. | ||
| command: | | ||
| ARGS=(juju wait-for ${{ inputs.type }} ${{ inputs.name }} --timeout=${{ inputs.timeout_minutes }}m) |
Contributor
There was a problem hiding this comment.
I think we can simplify this action and drop the wait-for for Juju 3.6 and just poll the status for all Juju versions. This would also save having to pass the Juju version.
Ninfa-Jeon
force-pushed
the
update-charmdef-juju4
branch
2 times, most recently
from
85181e8 to
6e0f862
Compare
Ninfa-Jeon
force-pushed
the
update-charmdef-juju4
branch
from
6e0f862 to
3e276ac
Compare
Ninfa-Jeon
force-pushed
the
update-charmdef-juju4
branch
from
ba9c17b to
a793361
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Done
juju-wait-foraction to usejuju statuspolling instead ofjuju wait-forcommand as it has been deprecated in 4.0. Refer this for more info.QA
Details
https://warthogs.atlassian.net/browse/WD-33971