Skip to content

Conversation

@gagath
Copy link
Contributor

@gagath gagath commented Nov 25, 2024

Allow easy copy-paste by chaining commands. Also remove unrequired chmod +x debian/rules.

Use multiline commands so users can copy/paste it at once instead of
having to do so for every line in the code block.

Signed-off-by: Agathe Porte <[email protected]>
The debian/rules file already has executable flag set after executing
`apt source`. This was verified for an old release as well (xenial).

Signed-off-by: Agathe Porte <[email protected]>
@gagath gagath requested a review from AnneCYH as a code owner November 25, 2024 09:57
fakeroot debian/rules clean
```
```{code-block} shell
chmod a+x debian/scripts/* && \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@khbecker could you take a look at this change?

@gagath , sorry, why don't we need the chmod for debian/rules?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AnneCYH see rationale in commit, quoting here for convenience:

The debian/rules file already has executable flag set after executing
apt source. This was verified for an old release as well (xenial).

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah thanks; i didn't expand the commits.
looks good then!

@AnneCYH AnneCYH merged commit c880d3d into main Nov 26, 2024
2 of 3 checks passed
@gagath gagath deleted the gagath/build-kernel-fixes branch November 27, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants