-
Notifications
You must be signed in to change notification settings - Fork 11
Review KE-209 test kernels in proposed #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The one-line deb source format for non-x86 on pre-noble systems mistakenly mentions /etc/apt/sources.list.d/ when the modification sould be made to /etc/apt/sources.list. Signed-off-by: Noah Wager <[email protected]>
Signed-off-by: Noah Wager <[email protected]>
Kernels can usually be installed either by directly installing the ABI-named linux-image package or by installing the flavour-named metapackage. Show both options. Also clarify that specifying the debian version is only for metapackages. Signed-off-by: Noah Wager <[email protected]>
d557779 to
127d13d
Compare
khbecker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
|
|
||
| ```{code-block} none | ||
| sudo apt install linux-<flavour> | ||
| sudo apt install linux-<flavour> # install kernel metapackage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @nwager , thanks for the additional details.
For the Ubuntu style guide, we don't encourage comments in the code block.
https://docs.ubuntu.com/styleguide/en/#code-examples-in-documentation
| ``` | ||
|
|
||
| Then install the kernel as per usual. If the kernel version in -proposed is the | ||
| highest in any pocket, install it by running: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @nwager , i propose to change the structure a little in this section
- It would help to briefly indicate why you would choose to install the metapackage vs ABI-named image
- For your original content, I think if you install the kernel via ABI-named image, the "kernel version being the highest in the proposed pocket" is not relevant I think since you specify the actual version.
This is my suggested edit; please do review & adjust as needed.
First, update the sources cache:
```{code-block} none
sudo apt update
```
Then proceed to install the kernel using either a metapackage or a specific
ABI-named image.
### Install via kernel metapackage
Use this approach if you want to receives automatic updates for the latest
version of the kernel in that series.
If the kernel version in -proposed is the highest in any pocket, run:
```{code-block} none
sudo apt install linux-<flavour>
```
If you want a specific (earlier) version of a metapackage, include the version
in the command:
```{code-block} none
sudo apt install linux-<flavour>=<version>
```
### Install via ABI-named kernel image
Use this method to install a specific kernel version without being tied to the
kernel series metapackage.
```{code-block} none
sudo apt install linux-image-<version>
```
Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, it makes more sense when things aren't haphazardly lumped together. Added this change pretty much verbatim in the recent commit e5b6767
AnneCYH
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @nwager , thanks for the update!
generally the changes look good and the additional details are helpful.
I have suggested some structural changes to improve the clarity of some sections; comments left for your consideration.
Thanks!
|
Hi @nwager , todo after the PR is merged
HTML output: https://canonical-kernel-docs.readthedocs-hosted.com/en/latest/how-to/testing-verification/test-kernel-in-proposed/ |
Since kernels can be installed via metapackages or directly with ABI-named packages, instead of lumping these steps in one block, split the various options into their own subsections. This briefly notes the differences and clarifies the steps to install the various packages. Signed-off-by: Noah Wager <[email protected]>
Signed-off-by: AnneCYH <[email protected]>
AnneCYH
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good; i'll go ahead and squash + merge, thanks for the effort @nwager !
Closes #11
The test-kernel-in-proposed doc needs a signoff after some edits. All the changes and fixes to my initial writeup look good. There were just a couple more details I wanted to add.