-
Notifications
You must be signed in to change notification settings - Fork 11
stable-patch-format: stricter rule for subject line + minor cosmetic changes #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
lkpdn
commented
Dec 20, 2024
- The flexible rule for subject line helps nobody. Let's make the most prevalent style the default in this doc.
- External contributers do not need to care about Acked-by tags when submitting patches. Drop it from the prep section to not confuse them.
- Some minor cosmetic changes.
AnneCYH
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @lkpdn , thanks for the updates.
I left some feedback; please do take a look and lemme know if you have any questions, thanks!
1b44592 to
f0b16e6
Compare
AnneCYH
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @lkpdn , a couple of nitpicks but otherwise all good, thanks!
803e692 to
b180250
Compare
|
Fixed author name and SOB tag (force-pushed). |
AnneCYH
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the changes @lkpdn , looks good!
gagath
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is long awaited, there have been to many different subject line formats on the ML preventing automation.
…changes * The flexible rule for subject line helps nobody. Let's make the most prevalent style the default in this doc. * External contributers do not need to care about Acked-by tags when submitting patches. Drop it from the prep section to not confuse them. * Some other cosmetic changes. Signed-off-by: Koichiro Den <[email protected]>
Co-authored-by: AnneCYH <[email protected]> Signed-off-by: Koichiro Den <[email protected]>
Co-authored-by: AnneCYH <[email protected]> Signed-off-by: Koichiro Den <[email protected]>
b180250 to
15f2df7
Compare