Skip to content

Conversation

@lkpdn
Copy link
Contributor

@lkpdn lkpdn commented Dec 20, 2024

  • The flexible rule for subject line helps nobody. Let's make the most prevalent style the default in this doc.
  • External contributers do not need to care about Acked-by tags when submitting patches. Drop it from the prep section to not confuse them.
  • Some minor cosmetic changes.

@lkpdn lkpdn requested a review from AnneCYH as a code owner December 20, 2024 01:22
@lkpdn lkpdn requested a review from smb49 December 20, 2024 01:49
Copy link
Collaborator

@AnneCYH AnneCYH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lkpdn , thanks for the updates.
I left some feedback; please do take a look and lemme know if you have any questions, thanks!

@lkpdn lkpdn force-pushed the kden/stable-patch-format branch from 1b44592 to f0b16e6 Compare January 8, 2025 07:06
@lkpdn
Copy link
Contributor Author

lkpdn commented Jan 8, 2025

@AnneCYH Thanks for the review, I applied all the feedback from you. (see f0b16e6)

Copy link
Collaborator

@AnneCYH AnneCYH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lkpdn , a couple of nitpicks but otherwise all good, thanks!

@lkpdn
Copy link
Contributor Author

lkpdn commented Jan 9, 2025

@AnneCYH Thanks again for the review. Applied all the feedback. (see 803e692.)

@lkpdn lkpdn force-pushed the kden/stable-patch-format branch from 803e692 to b180250 Compare January 9, 2025 06:56
@lkpdn
Copy link
Contributor Author

lkpdn commented Jan 9, 2025

Fixed author name and SOB tag (force-pushed).

@AnneCYH AnneCYH self-requested a review January 9, 2025 07:22
Copy link
Collaborator

@AnneCYH AnneCYH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the changes @lkpdn , looks good!

Copy link
Contributor

@gagath gagath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is long awaited, there have been to many different subject line formats on the ML preventing automation.

lkpdn and others added 3 commits February 12, 2025 07:20
…changes

* The flexible rule for subject line helps nobody. Let's make the most
  prevalent style the default in this doc.
* External contributers do not need to care about Acked-by tags when
  submitting patches. Drop it from the prep section to not confuse them.
* Some other cosmetic changes.

Signed-off-by: Koichiro Den <[email protected]>
@gagath gagath force-pushed the kden/stable-patch-format branch from b180250 to 15f2df7 Compare February 12, 2025 06:21
@gagath gagath merged commit c309cba into main Feb 12, 2025
4 checks passed
@gagath gagath deleted the kden/stable-patch-format branch February 12, 2025 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants