Respin how-to guide #57
Conversation
Signed-off-by: Benjamin Wheeler <[email protected]>
nukelet
left a comment
nukelet
left a comment
There was a problem hiding this comment.
this is great, thanks for taking the time to write it! i left a small nit comment but otherwise it looks good to me
Signed-off-by: Benjamin Wheeler <[email protected]>
Signed-off-by: Benjamin Wheeler <[email protected]>
Signed-off-by: Benjamin Wheeler <[email protected]>
benjamin051000
force-pushed
the
howto-respin
branch
from
b345223 to
5ac43c0
Compare
|
Content is finished at this point, please review and let me know what you think. |
benjamin051000
requested review from
gagath,
ijwhitfield,
nukelet and
tswhison
Signed-off-by: Benjamin Wheeler <[email protected]>
| ```{attention} | ||
| Only one person peforms this step. If you already have a Jira card, note the respin number in the card (see Note at the end of this step) and skip this step. | ||
| ``` |
There was a problem hiding this comment.
Is attention too harsh on the eyes? 🤷🏼♂️
There was a problem hiding this comment.
It does stand out, but I think that's ok.
There was a problem hiding this comment.
I would use Warning / Attention / Caution for something that you absolutely don't want someone to do without understanding the impact.
So in this case, if you DO create another Jira card, what happens?
| ```{note} | ||
| Note the respin number, as it's used in subsequent steps. | ||
| The respin number is in the title of the Jira card in parentheses. | ||
| For example, "Re-spin (#8)" indicates the number is 8. | ||
| ``` |
There was a problem hiding this comment.
This is important to read, even if you were told to skip this section... How should we make that more clear? Maybe it's clear enough as-is.
| On Launchpad, mark the original tracking bug as a duplicate of the newly-created bug. | ||
| <!-- TODO screenshots of how to do this --> |
There was a problem hiding this comment.
It would be nice to have a screenshot of how to do this in launchpad, it's not obvious to newbies (myself).
| You may also be asked to modify the commit message. | ||
| <!--TODO elaborate?--> |
There was a problem hiding this comment.
Should we elaborate? Is there a standard/convention we generally follow?
Signed-off-by: Benjamin Wheeler <[email protected]>
nukelet
left a comment
nukelet
left a comment
There was a problem hiding this comment.
the github review workflow is kind of unfamiliar to me so i ended up leaving comments before starting the review for good, but overall it looks good to me. most comments are just some relatively unimportant nits/observations
|
|
||
| It is possible to make changes before the SRU cycle closes. This is a special version of a crank called a respin. | ||
|
|
||
| These are the steps to respin a kernel, with examples from a previous `2025.01.13` respin of the `noble:linux-gke` kernel due to a late-cycle decision to revert a patchset. |
There was a problem hiding this comment.
Hey @benjamin051000 , i haven't finished reviewing this but a how-to shouldn't be too specific in terms of the scenarios described in the guide.
I would caution setting up this expectation by mentioning a specific cycle and kernel and reason for respin.
Signed-off-by: Benjamin Wheeler <[email protected]>
Signed-off-by: Benjamin Wheeler <[email protected]>
Signed-off-by: Benjamin Wheeler <[email protected]>
Co-authored-by: AnneCYH <[email protected]> Signed-off-by: Benjamin Wheeler <[email protected]>
Co-authored-by: AnneCYH <[email protected]> Signed-off-by: Benjamin Wheeler <[email protected]>
Signed-off-by: Benjamin Wheeler <[email protected]>
Signed-off-by: Benjamin Wheeler <[email protected]>
Signed-off-by: Benjamin Wheeler <[email protected]>
|
Closing this as this is moving to an internal repo. |
This is a new how-to guide on respin cranks.
Link to built docs (also at the bottom in the "Checks"): https://canonical-kernel-docs--57.com.readthedocs.build/en/57/how-to/respin/