generated from canonical/template-operator
-
Notifications
You must be signed in to change notification settings - Fork 5
Add refresh v3 implementation #241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
carlcsaposs-canonical
wants to merge
23
commits into
main
Choose a base branch
from
refresh-v3-draft
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
a1e0fb1
Add refresh v3 draft implementation
carlcsaposs-canonical 299cb22
Simplify reconcile
carlcsaposs-canonical db4ec41
Add `self._reconcile_allowed` instead of exiting
carlcsaposs-canonical 2d73aae
Sync with K8s
carlcsaposs-canonical dc6eae6
Remove workload version set
carlcsaposs-canonical 1485d04
Include logger name in logs
carlcsaposs-canonical 129a9ff
Update charm-refresh
carlcsaposs-canonical 4f96e5b
Update charm_refresh
carlcsaposs-canonical c7bdb38
Use JSON schema
carlcsaposs-canonical b02ca17
Use released charm-refresh
carlcsaposs-canonical 6115899
Update comment
carlcsaposs-canonical b25329e
Check workload version
carlcsaposs-canonical 78683ef
Update data-platform-workflows to v32.0.0
carlcsaposs-canonical 7d5e84b
Set charm refresh compatibility version from git tag
carlcsaposs-canonical 063bd7b
Format
carlcsaposs-canonical b83f971
Revert (for testing) "Set charm refresh compatibility version from gi…
carlcsaposs-canonical 937e692
Fix unit test mocks
carlcsaposs-canonical c28652c
Remove 20.04 base
carlcsaposs-canonical 2799d04
Format
carlcsaposs-canonical a30516e
Increase numprocesses to workaround memory leak
carlcsaposs-canonical 62d746a
Increase numprocesses to workaround memory leak
carlcsaposs-canonical fb9d59a
Set charm refresh compatibility version from git tag
carlcsaposs-canonical 5ec51eb
Revert (for testing) "Set charm refresh compatibility version from gi…
carlcsaposs-canonical File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,7 +3,7 @@ | |
|
||
type: charm | ||
platforms: | ||
[email protected]:amd64: | ||
# [email protected]:amd64: # TODO re-add after https://github.com/canonical/charmcraft/commit/65d01ed598a607eea9e2368da738117507e8024a lands in charmcraft stable | ||
[email protected]:amd64: | ||
[email protected]:arm64: | ||
# Files implicitly created by charmcraft without a part: | ||
|
@@ -87,15 +87,9 @@ parts: | |
build-packages: | ||
- git | ||
override-build: | | ||
# Workaround to add unique identifier (git hash) to charm version while specification | ||
# DA053 - Charm versioning | ||
# (https://docs.google.com/document/d/1Jv1jhWLl8ejK3iJn7Q3VbCIM9GIhp8926bgXpdtx-Sg/edit?pli=1) | ||
# is pending review. | ||
python3 -c 'import pathlib; import shutil; import subprocess; git_hash=subprocess.run(["git", "describe", "--always", "--dirty"], capture_output=True, check=True, encoding="utf-8").stdout; file = pathlib.Path("charm_version"); shutil.copy(file, pathlib.Path("charm_version.backup")); version = file.read_text().strip(); file.write_text(f"{version}+{git_hash}")' | ||
|
||
# TODO: set charm version in refresh_versions.toml | ||
craftctl default | ||
stage: | ||
- LICENSE | ||
- charm_version | ||
- workload_version | ||
- refresh_versions.toml | ||
- templates |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finally! THANK YOU!