Use Patroni API for is_restart_pending() #1095
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous is_restart_pending() waited for long due to the Patroni's loop_wait default value (10 seconds), which tells how much time Patroni will wait before checking the configuration file again to reload it. Instead of checking PostgreSQL pending_restart from pg_settings, let's check Patroni API pending_restart=True flag. Signed-off-by: Marcelo Henrique Neppel <[email protected]>
Codecov Report❌ Patch coverage is
❌ Your project check has failed because the head coverage (67.66%) is below the target coverage (70.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## 16/edge #1095 +/- ##
===========================================
- Coverage 67.81% 67.66% -0.15%
===========================================
Files 15 15
Lines 4129 4135 +6
Branches 606 604 -2
===========================================
- Hits 2800 2798 -2
- Misses 1106 1114 +8
Partials 223 223 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
marceloneppel
added
the
not bug or enhancement
The current Patroni 3.2.2 has wired/flickering behaviour:
it temporarily flag pending_restart=True on many changes to REST API,
which is gone within a second but long enough to be caught by charm.
Sleepping a bit is a necessary evil, until Patroni 3.3.0 upgrade.
The previous code sleept for 15 seconds waiting for pg_settings update.
Also, the unnecessary restarts could be triggered by missmatch of
Patroni config file and in-memory changes coming from REST API,
e.g. the slots were undefined in yaml file but set as an empty JSON {} => None.
Updating the default template to match the default API PATCHes and avoid restarts.
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
marceloneppel
force-pushed
the
is-restart-pending
branch
from
522b441 to
9e3c353
Compare
Merged
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous is_restart_pending() waited for long due to the Patroni's loop_wait default value (10 seconds), which tells how much time Patroni will wait before checking the configuration file again to reload it.
Instead of checking PostgreSQL pending_restart from pg_settings, let's check Patroni API pending_restart=True flag.
Issue
Solution
Checklist