Skip to content

[DPE-6752] Port over postgresql charm lib v1 to support predefined roles #956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: 16/edge
Choose a base branch
from

Conversation

shayancanonical
Copy link
Contributor

Issue

With the introduction of predefined roles in the VM operator, we introduce a lot of breaking changes in the postgresql charm lib (which we most likely do not want to backport to PG 14 branches).

Solution

Bump postgresql charm lib changes on charm lib v1

TODO

Add unit tests and fix existing unit tests

Checklist

  • [] I have added or updated any relevant documentation.
  • I have cleaned any remaining cloud resources from my accounts.

Copy link

codecov bot commented May 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.74%. Comparing base (1c90b97) to head (7417885).

Additional details and impacted files
@@           Coverage Diff            @@
##           16/edge     #956   +/-   ##
========================================
  Coverage    73.74%   73.74%           
========================================
  Files           12       12           
  Lines         3554     3554           
  Branches       509      509           
========================================
  Hits          2621     2621           
  Misses         738      738           
  Partials       195      195           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@shayancanonical shayancanonical added the enhancement New feature, UI change, or workload upgrade label May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, UI change, or workload upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant