-
Notifications
You must be signed in to change notification settings - Fork 21
Logical Replication #795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Logical Replication #795
Conversation
…d replication slots.
# Conflicts: # lib/charms/postgresql_k8s/v0/postgresql.py
…logical replication; add check on conflicting subscription name.
…ation; fix relations bugs.
…store check. Add missing async replication checks in pre restore checks.
# Conflicts: # lib/charms/postgresql_k8s/v0/postgresql.py # templates/patroni.yml.j2
Codecov ReportAttention: Patch coverage is
❌ Your patch check has failed because the patch coverage (19.28%) is below the target coverage (33.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #795 +/- ##
==========================================
- Coverage 72.08% 67.99% -4.10%
==========================================
Files 15 16 +1
Lines 3865 4255 +390
Branches 584 668 +84
==========================================
+ Hits 2786 2893 +107
- Misses 898 1174 +276
- Partials 181 188 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks great! I'll only do some more testing tomorrow.
Co-authored-by: Marcelo Henrique Neppel <[email protected]>
Co-authored-by: Marcelo Henrique Neppel <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Great work!
This is an implementation of the Logical Replication specification (WIP): https://docs.google.com/document/d/1f84Z4cZwUD4q4bJsXTTC_PUaZr7pPB0Q6HnQ9cgCX_o/edit?usp=sharing.
Basic testing
postgresql
andpostgresql2
juju integrate postgresql:logical-replication-offer postgresql2:logical-replication
postgresql
:create table asd (message text); insert into asd values ('hello');
postgresql2
sidejuju run postgresql/leader add-publication name=asd database=postgres tables=public.asd
juju run postgresql2/leader subscribe name=asd
postgresql2
side:select * from asd;
postgresql2
subscriberKey notes
postgesql-k8s
lib synced with K8s revision.