Conversation
943c614 to
9f87abf
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
Hi Pete sorry looked into accessibility best practices a little more - I'm not sure why but sometimes on loading the demo page, tabbing through the navigation comp keeps the focus area there, and sometimes using one of the anchor links to go into a content section shifts the focus to the content area. Could we ensure that we allow for the latter - i.e. tabbing through and jumping into content sections via the page navigation comp takes you through the links in the content area, rather than back to the navigation comp? Example functionality here Also @kim-isaac pointed out that when you tab through links in the content and the page scrolls down, the active tab in the navigation component doesn't seem to update - could we have the active tabs update as it would if you were scrolling through the page? Thank you! |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
…ion when in 'full-page' mode
a2263b6 to
3d45237
Compare
This comment was marked as resolved.
This comment was marked as resolved.
3d45237 to
662ccdc
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
LGTM thank you so much for all your work and patience on this Pete! |
|
@petesfrench There were a lot of comments and thank you so much for taking care of all of them! I'll also add +1 |
Done
QA
Documentation page
Full-page example
Manual example
Component example
Component no heading example
Changelog
Check if PR is ready for release
If this PR contains Vanilla SCSS or macro code changes, it should contain the following changes to make sure it's ready for the release:
Feature 🎁,Breaking Change 💣,Bug 🐛,Documentation 📝,Maintenance 🔨.package.jsonshould be updated relative to the most recent release, following semver conventionFixes
#5475