New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use default GOPATH, when env variable is empty #25

Open

bfanger wants to merge 1 commit into canthefason:master from bfanger:empty-gopath

bfanger commented May 19, 2018

When the GOPATH is empty (which is optional since go 1.8) the watcher panics

I've patched watcher.generateBinaryPrefix() to use:

gopath := os.Getenv("GOPATH")
if gopath == "" {
    gopath = build.Default.GOPATH
}

I also fixed some linter issues, so go test passes again.


          Use default GOPATH, when env variable is empty

bfb4fe0

bfanger mentioned this pull request

Panic when running watcher #22

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet