Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: postgres build plugin w --production #1018

Merged
merged 9 commits into from
Feb 9, 2025
Merged

Conversation

patricebender
Copy link
Member

@patricebender patricebender commented Feb 7, 2025

as reported in the issue, with default cds build --production no postgres build artifacts have been generated.

this was due to a misconfiguration in our postgres/package.json


cds init reproduce --add tiny-sample
cd reproduce
cds add postgres

you can now observe the malformed cds env

❯ cds env requires.db --profile production
{
  impl: '@cap-js/postgres',
  credentials: { url: 'db.sqlite' },
  kind: 'sqlite',
  dialect: 'postgres',
  vcap: { label: 'postgresql-db' },
  schema_evolution: 'auto'
}

and the broken build (missing postgres build task):

❯ cds build --production
building project [/Users/patricebender/SAPDevelop/dev/cds-dbs/postgres/test/tiny-sample], clean [true]
cds-dk [8.7.1], cds [8.8.0], compiler [5.7.5], home [/Users/patricebender/SAPDevelop/dev/cds]

{
  build: {
    target: 'gen',
    tasks: [
      { for: 'nodejs', src: 'srv', options: { model: ['db', 'srv'] }}
    ]
  }
}

@patricebender patricebender changed the title fix: postgres config fix: postgres build plugin w --production Feb 7, 2025
@patricebender
Copy link
Member Author

in this workflow run, the issue has been reproduced: https://github.com/cap-js/cds-dbs/actions/runs/13201485026/job/36854354861?pr=1018#step:7:229

@patricebender patricebender enabled auto-merge (squash) February 7, 2025 14:19
@patricebender patricebender merged commit aafffc9 into main Feb 9, 2025
6 checks passed
@patricebender patricebender deleted the patricebender-patch-1 branch February 9, 2025 12:40
@cap-bots cap-bots mentioned this pull request Feb 9, 2025
patricebender pushed a commit that referenced this pull request Feb 9, 2025
🤖 I have created a release *beep* *boop*
---


<details><summary>db-service: 1.17.2</summary>

##
[1.17.2](db-service-v1.17.1...db-service-v1.17.2)
(2025-02-09)


### Fixed

* replace polynomial regex with simple string op
([#1015](#1015))
([3fe6e6b](3fe6e6b))
</details>

<details><summary>postgres: 1.11.1</summary>

##
[1.11.1](postgres-v1.11.0...postgres-v1.11.1)
(2025-02-09)


### Fixed

* postgres build plugin w `--production`
([#1018](#1018))
([aafffc9](aafffc9))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cds deploy - don't generate datas since 1.11 version
3 participants