-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: postgres build plugin w --production
#1018
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BobdenOs
approved these changes
Feb 7, 2025
patricebender
commented
Feb 7, 2025
--production
swaldmann
approved these changes
Feb 7, 2025
in this workflow run, the issue has been reproduced: https://github.com/cap-js/cds-dbs/actions/runs/13201485026/job/36854354861?pr=1018#step:7:229 |
Merged
patricebender
pushed a commit
that referenced
this pull request
Feb 9, 2025
🤖 I have created a release *beep* *boop* --- <details><summary>db-service: 1.17.2</summary> ## [1.17.2](db-service-v1.17.1...db-service-v1.17.2) (2025-02-09) ### Fixed * replace polynomial regex with simple string op ([#1015](#1015)) ([3fe6e6b](3fe6e6b)) </details> <details><summary>postgres: 1.11.1</summary> ## [1.11.1](postgres-v1.11.0...postgres-v1.11.1) (2025-02-09) ### Fixed * postgres build plugin w `--production` ([#1018](#1018)) ([aafffc9](aafffc9)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as reported in the issue, with default
cds build --production
no postgres build artifacts have been generated.this was due to a misconfiguration in our
postgres/package.json
cds init reproduce --add tiny-sample cd reproduce cds add postgres
you can now observe the malformed
cds env
and the broken build (missing postgres build task):