Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Support all SELECT properties in path expressions #1048

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

BobdenOs
Copy link
Contributor

No description provided.

Comment on lines +237 to +243
const query = cds.ql`SELECT FROM ${Books}[
where ID > 210
group by title
having computed
order by title desc
limit 2
] {
Copy link
Member

@patricebender patricebender Feb 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are the semantics of those properties if they are not part of the leaf-ref of a from clause? E.g.:

cds.ql`SELECT FROM Authors {
      books[
        where ID > 210
        group by title
        having computed
        order by title desc
        limit 2
    ].title as top2
  }`

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • order by, limit, and group by are only reasonable for expands
  • where is also reasonable for inlines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants