refactor: standard database functions #985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- [] factor out SQLite specific functions from base class
- [] align jsdoc with capire
- [] `cql-functions` in the db-service becomes `sql-functions`
and a new interface `cql-functions` is added containing
the set of functions which shall be implemented by the dbs themselves
this would enable also overwriting/re-using `cql-functions` for non-sql dbs
patricebender
requested review from
BobdenOs,
gregorwolf,
sebastianesch,
vobu,
danjoa,
johannes-vogel,
stewsk,
sjvans and
David-Kunz
as code owners
BobdenOs
reviewed
Feb 14, 2025
db-service/lib/cql-functions.js
Outdated
| * @param {string} y right timestamp | ||
| * @returns {string} | ||
| * Generates SQL statement for the current date | ||
| * @param {string} [p] - Optional parameter |
There was a problem hiding this comment.
is p allowed according to ANSI SQL ? My understanding is that p is only allowed by certain databases.
There was a problem hiding this comment.
No, at least not for current_date (I didn't add this in this PR though),
this and excerpt from ANSI SQL 2003:
<current date value function> ::= CURRENT_DATE
<current time value function> ::=
CURRENT_TIME [ <left paren> <time precision> <right paren> ]
<current local time value function> ::=
LOCALTIME [ <left paren> <time precision> <right paren> ]
<current timestamp value function> ::=
CURRENT_TIMESTAMP [ <left paren> <timestamp precision> <right paren> ]
<current local timestamp value function> ::=
LOCALTIMESTAMP [ <left paren> <timestamp precision> <right paren> ]
Looks like the precision is ok for the others. I would then remove it from current_date would you agree?
BobdenOs
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HANAServicealso requiresdb-service/cql-functionsand then also supportsfloor,ceiling,average…totalsecondscql-functionsin the db-service becomessql-functionsand a new interfacecql-functionsis added containing the set of functions which shall be implemented by the dbs themselves this would enable also overwriting/re-usingcql-functionsfor non-sql dbs