Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
SAP Passport
is only updated whenprepare
andexec
are called, but it is required to update every time the database is called. Therefor this PR shifts theSAP Passport
criteria to usingprom
. Which is the re use function@cap-js/hana
uses inside its generic driver wrappers to promisify the native driver functions. Therefor by tracing theprom
function it traces all* driver calls and ensures that theSAP Passport
contains an unique trace ID which open telemetry can anchor itself onto. As without the round trip specific parent trace ID the open telemetry service provider will see the child trace timestamps outside of the parent trace window and try to adjust the timestamp into the parent trace time frame. Which gets especially confusing when the parent time frame is smaller then the child time frame.It still has to be investigated how well the
prom
wrapping approach works for theresultset streaming
(cap-js/cds-dbs#702) feature.