Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Keep SAP Passport up-to-date #283

Merged
merged 6 commits into from
Feb 5, 2025
Merged

fix: Keep SAP Passport up-to-date #283

merged 6 commits into from
Feb 5, 2025

Conversation

BobdenOs
Copy link
Contributor

@BobdenOs BobdenOs commented Feb 3, 2025

Currently SAP Passport is only updated when prepare and exec are called, but it is required to update every time the database is called. Therefor this PR shifts the SAP Passport criteria to using prom. Which is the re use function @cap-js/hana uses inside its generic driver wrappers to promisify the native driver functions. Therefor by tracing the prom function it traces all* driver calls and ensures that the SAP Passport contains an unique trace ID which open telemetry can anchor itself onto. As without the round trip specific parent trace ID the open telemetry service provider will see the child trace timestamps outside of the parent trace window and try to adjust the timestamp into the parent trace time frame. Which gets especially confusing when the parent time frame is smaller then the child time frame.

image

It still has to be investigated how well the prom wrapping approach works for the resultset streaming (cap-js/cds-dbs#702) feature.

@sjvans
Copy link
Contributor

sjvans commented Feb 5, 2025

requires cap-js/cds-dbs#1008

@sjvans sjvans enabled auto-merge (squash) February 5, 2025 20:48
@sjvans sjvans merged commit 0443714 into main Feb 5, 2025
4 checks passed
@sjvans sjvans deleted the fix/sap-passport-hana branch February 5, 2025 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants