Skip to content

Complete overhaul version 2 #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 38 commits into
base: master
Choose a base branch
from
Open

Complete overhaul version 2 #7

wants to merge 38 commits into from

Conversation

lordelph
Copy link

A bit of a big one this!

  • MIT License - prior releases were GPL
  • PSR-2 formatting/naming conventions, including change of classname from sip2 to SIP2Client
  • PSR-3 logger support
  • Classes for each request and response type
  • Support for binding to particular interface
  • Support for Travis CI & Scrutinizer
  • Full unit tests

lordelph added 30 commits July 11, 2018 00:19
@lordelph
Rename class to SIP2Client and adopt PSR-2 formatting and PSR-4 autol…
a514527 
…oading

Change to MIT with permission of original author
Improve composer.json with addition targets for testing and formatting
Add additional documentation files
@lordelph
Refactored SIP2Client to use a socket factory to facilitate testing
beda827
@lordelph
Add basic unit test which demonstrates mocking server responses
25f3fcd
@lordelph
Corrected phpunit.xml to bring it up to date
d1b6038
@lordelph
Refactor and expand test suite
3152fe0
@lordelph
Ensure parseHoldResponse copes with optional elements
068883b
@lordelph
Corrected method name
bc21713
@lordelph
Add tests for fee-paid and end-patron-session
fb76cae
@lordelph
Complete coverage of hold message generation
9656efd
@lordelph
Full test coverage
b8b1cb0
@lordelph
Fix getMessage to return retried response and minor test coverage adj…
3317b34 
…ustments
@lordelph
Add ability to bind to specific outbound IP
05231c7
@lordelph
Add support for PSR-3 logger
37141ea
@lordelph
Rename some member variables for clarity and improve comments on each
dc34ab5
@lordelph
Add documentation for all public methods
fa03dbe
@lordelph
Ensure composer and CI only target php7+
c0c6c6f
@lordelph
Only send one code coverage run to scrutinizer
dda41b6
@lordelph
Added experimental outline of broken out request class
4dcd04d
@lordelph
Flesh out changelog and readme for v2
2e83c23
@lordelph
Expand migration section
2cc0134
@lordelph
Merge branch 'v2' into breakout
36256de
@lordelph
Refactor parsing/request building into separate classes
dc8038d
@lordelph
Improve and clean up phpdoc comments
f7bdbbb
@lordelph
Improve migration documentation
4fa2188
@lordelph
Improve phpdoc comments
d176f7f
@lordelph
Improve phpdoc comments
7c8c7d6
@lordelph
Add setDefault and remove no-longer-required member variables
13405ad
@lordelph
Add casts to deal with scrutinizer warning
977034b
@lordelph
Add test for setDefault
2dc8ab1
@lordelph
Corrected phpdoc comment
80bc453
@lordelph
Copy link
Author

After merging this, you should be able to login to https://travis-ci.org/ and https://scrutinizer-ci.com/ and have them automatically run test and check code quality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@donli12 donli12 donli12 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lordelph @donli12