Test for asserts #35
Merged
Test for asserts #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agoerler
commented
Jan 7, 2026
| CqnInsert insert = Insert.into(TRAVELS).entry(travel); | ||
|
|
||
| assertThatExceptionOfType(ServiceException.class) | ||
| .isThrownBy(() -> srv.run(insert)).satisfies(badRequest("Customer does not exist", "Customer_ID")); |
Contributor
Author
There was a problem hiding this comment.
@beckermarc, @StefanHenke - why is the target here Customer_ID but on line 65 it's Customer?
Collaborator
There was a problem hiding this comment.
You only assert the service exception. There are additional error messages in the messages bag. There you will find additional errors for Customer_ID for both variants the error message from @mandatory and the one from the @assert annotation. I think we should avoid this double duplication.
- Either we use the @Assert or the @mandatory to check for
null - We should annotate the foreign key Customer.ID instead of Customer to avoid duplicating the annotations across association and foreign key.
beckermarc
reviewed
Jan 9, 2026
srv/src/test/java/sap/capire/xtravels/handler/TravelServiceTest.java
Outdated
Show resolved
Hide resolved
beckermarc
approved these changes
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.