Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include _custom_build in sdist #369

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Include _custom_build in sdist #369

merged 1 commit into from
Sep 25, 2024

Conversation

kvelicka
Copy link
Contributor

This fixes build issues for installations that cannot use wheels published on PyPI. Issue #364 would be fixed by this.

Python build tools like python -m build first build a source distribuiton (sdist) and then use it (and only it) to build a binary wheel from. This doesn't work if one of the build scripts isn't in the sdist however, which was the case prior to this patch.

This fixes build issues for installations that cannot use wheels
published on PyPI. Issue capnproto#364 would be fixed by this.

Python build tools like `python -m build` first build a source
distribuiton (sdist) and then use it (and only it) to build a binary
wheel from. This doesn't work if one of the build scripts isn't in the
sdist however, which was the case prior to this patch.
@haata haata merged commit 59a639f into capnproto:master Sep 25, 2024
12 checks passed
@haata
Copy link
Collaborator

haata commented Sep 25, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants