-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Xtensa Support #2380
Xtensa Support #2380
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please keep in mind the LITBASE
mechanic Xtensa has.
No other disassembler seems to support it. So it would be nice if CS gives at least an option to take care of it.
See: https://youtu.be/QMO2vMBcx7Y?feature=shared&t=808
@imbillow what LLVM version you have used as a base for this PR? Mainstream LLVM 18? Or a fork from developers working on the Xtensa patches? |
I'm using the auto-sync branch of llvm-capstone, I think it's llvm-18, I'm not sure.
|
It is LLVM 18. Please quickly diff the |
This comment was marked as resolved.
This comment was marked as resolved.
@imbillow I fixed some issue while being at it: imbillow#1 Please check this issue here with
Also, it is weird. But in the CI it builds Xtensa without my edits. But it shouldn't because those macros don't exist. Or did you add them and I just overlooked them? |
- fix MCExpr - fix Xtensa_add_cs_detail - add `add_cs_detail` - add `MCExpr *MCOperand_getExpr(const MCOperand *MC)` `void printExpr(const MCExpr *E, SStream *O)` autosync fix - fix StreamOperation.py - replace `report_fatal_error` with `CS_ASSERT` - fix patch StreamOperation.py - replace `assert` with `CS_ASSERT` - fix AddCSDetail.py - fix QualifiedIdentifier
a4c5b12
to
d64195c
Compare
The clang-tidy warnings are a false positive, because |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kabeor Your turn
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WoW, really cool, thanks!
Your checklist for this pull request
Detailed description
...
Test plan
...
Closing issues
...