Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coverity defects #2469

Merged
merged 56 commits into from
Sep 18, 2024
Merged

Coverity defects #2469

merged 56 commits into from
Sep 18, 2024

Conversation

Rot127
Copy link
Collaborator

@Rot127 Rot127 commented Sep 3, 2024

Your checklist for this pull request

  • I've documented or updated the documentation of every API function and struct this PR changes.
  • I've added tests that prove my fix is effective or that my feature works (if possible)

Detailed description

Fixes all Coverity and clang-tidy defects.
Additionally it partially fixes #2471 (too low operand count).

Test plan

Added where applicable.

Closing issues

closes #2302
closes #2475
closes #2376
closes #2438

@Rot127
Copy link
Collaborator Author

Rot127 commented Sep 5, 2024

@R33v0LT Can you please provide me a test case for the fix in 8f91971 and c32a2a4 and da8e1ab

@Rot127
Copy link
Collaborator Author

Rot127 commented Sep 5, 2024

@imbillow Please check 20edb70

@Rot127
Copy link
Collaborator Author

Rot127 commented Sep 6, 2024

@imbillow Also check e1e5f1c and provide me with a test case, please.

Copy link
Member

@kabeor kabeor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, merged.

@kabeor kabeor merged commit 3a2cd3c into capstone-engine:next Sep 18, 2024
19 checks passed
@XVilka
Copy link
Contributor

XVilka commented Sep 18, 2024

@kabeor could you please also merge these while you are on it (using rebase)?

They are relatively small, you can review them by checking specific commits

@Rot127 Rot127 deleted the coverity-defects branch September 19, 2024 07:53
@Rot127 Rot127 mentioned this pull request Sep 19, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment