-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename CS_OPT_NO_BRANCH_OFFSET and corresponding flag to better name. #2482
Open
Rot127
wants to merge
140
commits into
capstone-engine:next
Choose a base branch
from
Rot127:branch-as-offset
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
X86
Arch
ARM
Arch
Mips
Arch
AArch64
Arch
Alpha
Arch
M680X
Arch
M68K
Arch
MOS65XX
Arch
PowerPC
Arch
RISCV
Arch
SH
Arch
Sparc
Arch
SystemZ
Arch
TriCore
Arch
WASM
Arch
XCore
Arch
python
bindings
CS-core-files
auto-sync
LLVM-core-files
auto-sync
Auto-Sync-files
Auto-Sync
LLVM-generated-files
Documentation
HPPA
Arch
LoongArch
Arch
Github-files
Github related files
labels
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
AArch64
Arch
Alpha
Arch
ARM
Arch
Auto-Sync-files
Auto-Sync
CS-core-files
auto-sync
Documentation
Github-files
Github related files
HPPA
Arch
LLVM-core-files
auto-sync
LLVM-generated-files
LoongArch
Arch
M68K
Arch
M680X
Arch
Mips
Arch
MOS65XX
Arch
PowerPC
Arch
python
bindings
RISCV
Arch
SH
Arch
Sparc
Arch
SystemZ
Arch
TriCore
Arch
WASM
Arch
X86
Arch
XCore
Arch
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
based on: #2476
Detailed description
Rename
CS_OPT_NO_BRANCH_OFFSET
and corresponding flag to better name.The previous name was very much not clear and should be replaced before the release.
Test plan
All green
Closing issues
...