UIShell components: rename "isOpen" prop to "open"#1876
Open
daviseidel wants to merge 3 commits intocarbon-design-system:masterfrom
Open
UIShell components: rename "isOpen" prop to "open"#1876daviseidel wants to merge 3 commits intocarbon-design-system:masterfrom
daviseidel wants to merge 3 commits intocarbon-design-system:masterfrom
Conversation
theetrain
reviewed
Jan 2, 2024
Contributor
There was a problem hiding this comment.
Thank you, overall this works and helps with #1621
When you have a moment, please update parts in /docs where UIShell is used with the open prop, and generated docs:
- Run
yarn build:docsandyarn build:lib -
/docs/src/pages/framed/UIShell/examples -
docs/src/pages/_layout.svelte - Anywhere else UIShell components are used
Author
|
Fixed all instances I could find. Tell me if I missed any. |
metonym
force-pushed
the
master
branch
3 times, most recently
from
234c1f9 to
e774974
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solving issue #461, it will bring more consistency, as now all components use
openprop instead ofisOpen