feat(combo-box): support TypeScript generics #2271
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports #2285
DataTablealready supports generics for row data, which greatly enhances DX (local IDE typeahead, type safety, etc..).This PR updates
ComboBoxwith a similar feature. It now supports TypeScript generics onitems, allowing type-safe access to custom item properties in callbacks, events, and slots.This is highly useful when storing/passing additional properties on
items.This change should be backward compatible; omitting the generic type parameter defaults to
ComboBoxItem.Example Usage
The
priceandcategoryfields are automatically inferred.