Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #374
Headers with images to one side are often tricky to produce neatly within a formal column layout system as defined by Carbon.
This PR hosts the whole header in a single column and uses CSS directly, following the spirit of Carbon, to provide a more pleasing responsive behaviour. The aspect ratio was also not providing us with any benefit on narrower screens as the content, constrained by width, grew taller than the ratio.
##Before large
After large
Before 1057px
After 1057px
Before 1055px
After 1055px
Before 672px
After 672px
Before 640px
After 640px
Before 320px
After 320px