Skip to content

Conversation

@riddhybansal
Copy link
Contributor

@riddhybansal riddhybansal commented Nov 25, 2025

Closes #20335
Closes #21079

New fluid password input web-component

Changelog

New

  • New fluid password input web-component
  • Added Test cases for the same

Testing / Reviewing

Fluid Password Input should work as intended as per react

PR Checklist

As the author of this PR, before marking ready for review, confirm you:

  • Reviewed every line of the diff
  • Updated documentation and storybook examples
  • Wrote passing tests that cover this change
  • Addressed any impact on accessibility (a11y)
  • Tested for cross-browser consistency
  • Validated that this code is ready for review and status checks should pass

More details can be found in the pull request guide

@riddhybansal riddhybansal requested a review from a team as a code owner November 25, 2025 14:20
@netlify
Copy link

netlify bot commented Nov 25, 2025

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit b4618ea
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-web-components/deploys/6925bb4882f6230008d927e1
😎 Deploy Preview https://deploy-preview-21078--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link

codecov bot commented Nov 25, 2025

Codecov Report

❌ Patch coverage is 98.41270% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 92.60%. Comparing base (8b2a5d5) to head (cb70394).
⚠️ Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...nents/fluid-password-input/fluid-password-input.ts 97.43% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #21078      +/-   ##
==========================================
- Coverage   92.62%   92.60%   -0.02%     
==========================================
  Files         515      516       +1     
  Lines       38222    38277      +55     
  Branches     5859     5872      +13     
==========================================
+ Hits        35403    35448      +45     
- Misses       2670     2679       +9     
- Partials      149      150       +1     
Flag Coverage Δ
main-packages 85.61% <ø> (ø)
web-components 96.88% <98.41%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@netlify
Copy link

netlify bot commented Nov 25, 2025

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit b4618ea
🔍 Latest deploy log https://app.netlify.com/projects/carbon-elements/deploys/6925bb4759d41e00082f8bb5
😎 Deploy Preview https://deploy-preview-21078--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Nov 25, 2025

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit b4618ea
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-react/deploys/6925bb470e894a0008f39564
😎 Deploy Preview https://deploy-preview-21078--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Nov 25, 2025

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit cb70394
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-web-components/deploys/6925c6782024750008520959
😎 Deploy Preview https://deploy-preview-21078--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Nov 25, 2025

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 2890fd4
🔍 Latest deploy log https://app.netlify.com/projects/carbon-elements/deploys/6925bb5c4279b200089fd72a
😎 Deploy Preview https://deploy-preview-21078--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Nov 25, 2025

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 2890fd4
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-react/deploys/6925bb5c0e10360008cafcd4
😎 Deploy Preview https://deploy-preview-21078--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Nov 25, 2025

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit cb70394
🔍 Latest deploy log https://app.netlify.com/projects/carbon-elements/deploys/6925c6783d059e0008012703
😎 Deploy Preview https://deploy-preview-21078--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Nov 25, 2025

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit cb70394
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-react/deploys/6925c678afb1340008709b70
😎 Deploy Preview https://deploy-preview-21078--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@riddhybansal
Copy link
Contributor Author

There is a bug with password input and hence with fluid password input. Here is the link

@heloiselui
Copy link
Contributor

Fluid PasswordInput:

  • In React: I think it’s worth opening an issue for React because the labelText and the placeholder prop are not working.

  • I noticed a difference in the icon position between WC and React.

WC:
Placeholder text

React:
Placeholder text

  • When ReadOnly=true + invalid=true, a red border appears.

WC:
Pasted Graphic 10

React:
Pasted Graphic 11

The tooltip position in WC looks different.

WC:
Hide password label

React:
Placeholder text

  • Using the keyboard in React: when I press Tab, it focuses on the entire input, when I press Tab again, it moves to the icon. In Web Components, this isn’t the case. The focus is actually working correctly, it’s being directed as expected, but the blue focus border just needs to be included.


bug.mov

WC:
aasasas

React:
Placeholder text

Copy link
Contributor

@2nikhiltom 2nikhiltom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[fluid-password-input]: Add unit test cases React|WC Parity: Create FluidPasswordInput

3 participants