-
Notifications
You must be signed in to change notification settings - Fork 2.1k
feat: fluid password input #21078
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: fluid password input #21078
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #21078 +/- ##
==========================================
- Coverage 92.62% 92.60% -0.02%
==========================================
Files 515 516 +1
Lines 38222 38277 +55
Branches 5859 5872 +13
==========================================
+ Hits 35403 35448 +45
- Misses 2670 2679 +9
- Partials 149 150 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
2890fd4 to
2948b55
Compare
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
148d75f to
cba3108
Compare
|
There is a bug with password input and hence with fluid password input. Here is the link |
|
Fluid PasswordInput:
The tooltip position in WC looks different.
bug.mov |
2nikhiltom
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good








Closes #20335
Closes #21079
New fluid password input web-component
Changelog
New
Testing / Reviewing
Fluid Password Input should work as intended as per react
PR Checklist
As the author of this PR, before marking ready for review, confirm you:
More details can be found in the pull request guide