-
Notifications
You must be signed in to change notification settings - Fork 2.1k
fix: focus sentinel text being read by jaws #21123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: focus sentinel text being read by jaws #21123
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #21123 +/- ##
=======================================
Coverage 92.60% 92.61%
=======================================
Files 515 515
Lines 38225 38225
Branches 5871 5813 -58
=======================================
+ Hits 35399 35401 +2
+ Misses 2676 2675 -1
+ Partials 150 149 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
tay1orjones
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIRC in the past aria-hidden wasn't put on the sentinel nodes because they're technically still focusable and shouldn't be removed from the accessibility tree. There might be some past issue/discussions on the topic.
Ahh... yeah I'm missing any of that past discussion... and with the ability to use feature flags to get around the sentinel issue, should we just close this @tay1orjones? |
|
@jlongshore @tay1orjones I think we still want the updated feature flag naming you have here regardless even if we revert the aria-hidden change? |
Closes #16389
Visually hidden link "Focus sentinel" is announced by the screen reader before notifications title and after close button.
Changelog
Changed
aria-hiddenproperties to visually hidden "Focus sentinel" elements.ComposedModal.featureflag.stories.jsandModal.featureflag.stories.js) referring to theenable-preview-focus-wrap-without-sentinelsfeature flag, which I couldn't find in the codebase, so I renamed toenable-focus-wrap-without-sentinels.Testing / Reviewing
aria-hidden, focus trapping appeared to work as beforePR Checklist
As the author of this PR, before marking ready for review, confirm you:
Wrote passing tests that cover this changeMore details can be found in the pull request guide