Skip to content

Conversation

@jlongshore
Copy link

Closes #16389

Visually hidden link "Focus sentinel" is announced by the screen reader before notifications title and after close button.

Changelog

Changed

  • Added aria-hidden properties to visually hidden "Focus sentinel" elements.
  • Noticed a few stories (ComposedModal.featureflag.stories.js and Modal.featureflag.stories.js) referring to the enable-preview-focus-wrap-without-sentinels feature flag, which I couldn't find in the codebase, so I renamed to enable-focus-wrap-without-sentinels.

Testing / Reviewing

  • Ran storybook, visually inspected elements for aria-hidden, focus trapping appeared to work as before
  • Updated snapshots / ran (and passed) tests
  • Solution seems to follow "Passed Example 4" found on w3c
  • Needs testing with assistive application like JAWS or similar (Tried with VoiceOver built into mac, but it doesn't seem to honor aria labels very well)

PR Checklist

As the author of this PR, before marking ready for review, confirm you:

  • Reviewed every line of the diff
  • Updated documentation and storybook examples
  • Wrote passing tests that cover this change
  • Addressed any impact on accessibility (a11y)
  • Tested for cross-browser consistency
  • Validated that this code is ready for review and status checks should pass

More details can be found in the pull request guide

@jlongshore jlongshore requested a review from a team as a code owner December 3, 2025 23:01
@netlify
Copy link

netlify bot commented Dec 3, 2025

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 23890d7
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-web-components/deploys/6930c146d53ce9000845d4e1
😎 Deploy Preview https://deploy-preview-21123--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Dec 3, 2025

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 23890d7
🔍 Latest deploy log https://app.netlify.com/projects/carbon-elements/deploys/6930c14676e5a80008cbccce
😎 Deploy Preview https://deploy-preview-21123--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link

codecov bot commented Dec 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.61%. Comparing base (6e1243f) to head (e4106a0).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #21123   +/-   ##
=======================================
  Coverage   92.60%   92.61%           
=======================================
  Files         515      515           
  Lines       38225    38225           
  Branches     5871     5813   -58     
=======================================
+ Hits        35399    35401    +2     
+ Misses       2676     2675    -1     
+ Partials      150      149    -1     
Flag Coverage Δ
main-packages 85.61% <ø> (ø)
web-components 96.89% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@netlify
Copy link

netlify bot commented Dec 3, 2025

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 23890d7
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-react/deploys/6930c1461fe5e30008e146b9
😎 Deploy Preview https://deploy-preview-21123--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Dec 3, 2025

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit e4106a0
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-web-components/deploys/6931e87088e4f500081b341f
😎 Deploy Preview https://deploy-preview-21123--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Dec 3, 2025

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit e4106a0
🔍 Latest deploy log https://app.netlify.com/projects/carbon-elements/deploys/6931e87061ba9700081f60d8
😎 Deploy Preview https://deploy-preview-21123--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Dec 3, 2025

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit e4106a0
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-react/deploys/6931e870f3353600070b64d7
😎 Deploy Preview https://deploy-preview-21123--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC in the past aria-hidden wasn't put on the sentinel nodes because they're technically still focusable and shouldn't be removed from the accessibility tree. There might be some past issue/discussions on the topic.

@jlongshore
Copy link
Author

IIRC in the past aria-hidden wasn't put on the sentinel nodes because they're technically still focusable and shouldn't be removed from the accessibility tree. There might be some past issue/discussions on the topic.

Ahh... yeah I'm missing any of that past discussion... and with the ability to use feature flags to get around the sentinel issue, should we just close this @tay1orjones?

@alisonjoseph
Copy link
Member

@jlongshore @tay1orjones I think we still want the updated feature flag naming you have here regardless even if we revert the aria-hidden change?

@alisonjoseph alisonjoseph removed the a11y: JAWS Screen reader issues, specifically JAWS label Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[a11y]: Notifications - Actionable Link focus sentinel

3 participants