style(tokens): update label to helper-text #21133
Open
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #21133 +/- ##
=======================================
Coverage 92.61% 92.61%
=======================================
Files 515 515
Lines 38225 38225
Branches 5813 5873 +60
=======================================
Hits 35401 35401
+ Misses 2675 2674 -1
- Partials 149 150 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
alisonjoseph
approved these changes
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19462
Switch validation messages (
invalidTextandwarnText) fromlabeltohelper-textback to thehelper-texttoken instead oflabel.I checked where the validation text actually comes from, so anything using
useNormalizedInputProps, likeTextInput,Dropdown,NumberInput,Slider,RadioButton,TimePicker, etc., ends up rendering a<className="…form-requirement">. Once we swapped the Sass for.form-requirementtohelper-text-01, every one of those components picked up the new token automatically. Even components with custom markup, likeFileUploader, the checkbox/radio group wrappers, or the list-box family, still style their validation blocks with.form-requirement, so they get the same change through the shared mixin. (ProgressBaralready matched)Changelog
New
None.Changed
.cds--form-requirement, which everyuseNormalizedInputPropsconsumer renders for validation (TextInput,Dropdown,NumberInput,Slider,RadioButton,TimePickeretc.), now useshelper-text-01instead oflabel-01.FileUploader’scustom validation blocks (title + supplement inside an invalid row and the deprecated summary block) also switch tohelper-text-01so its errors match the sharedhelper textstyle.Removed
None.Testing / Reviewing
React or WC Deploy Preview> check any component (TextInput,Dropdown,NumberInput,Slider,RadioButton,TimePicker, etc.), setinvalid=trueorwarn=true, inspect the validation message and confirm.cds--form-requirementcomputes to thehelper-texttoken.Screen.Recording.2025-12-05.at.11.43.19.mov
PR Checklist
As the author of this PR, before marking ready for review, confirm you:
[ ] Updated documentation and storybook examples[ ] Wrote passing tests that cover this change[ ] Addressed any impact on accessibility (a11y)[ ] Tested for cross-browser consistencyMore details can be found in the pull request guide