fix(data-table): maintain row size hierarchy when content wraps - #22629
fix(data-table): maintain row size hierarchy when content wraps#22629jesnajoseijk wants to merge 8 commits into
Conversation
|
All contributors have signed the DCO. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #22629 +/- ##
==========================================
- Coverage 89.60% 89.59% -0.01%
==========================================
Files 582 582
Lines 53279 53279
Branches 7260 7312 +52
==========================================
- Hits 47739 47737 -2
- Misses 5403 5405 +2
Partials 137 137
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
2cd66e2 to
8205651
Compare
adamalston
left a comment
There was a problem hiding this comment.
I think some of the checklist items in the description should be updated based on the guidance provided in the template.
carbon/.github/PULL_REQUEST_TEMPLATE.md
Line 28 in 845756c
|
Hi @jesnajoseijk! Thanks for working on this, can you please also fix the same for web components? |
There was a problem hiding this comment.
Looking through the UI Tests: @carbon/react storybook snapshots that have changed on Chromatic, I would expect there to be no change to any of the stories because none of them have wrapping text and this PR doesn't change any of the stories. It would make sense to update one of the stories to have longer text to showcase this bug being fixed.
So two things:
- The fix should not impact the visuals/snaps of existing stories at all
- A story should be updated to contain wrapping text showcasing the fix, which should cause only those chromatic snaps to change
✅ Deploy Preview for v2-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v3-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Closes #20759
I have read the DCO document and I hereby sign the DCO. Each contributor must post that comment from their GitHub account so the action records their signature.
Fixes a DataTable issue where wrapped cell content could make
size="md"rows taller thansize="lg".Changelog
New
Changed
lgvertical padding for DataTable header labels and body cellsRemoved
Testing / Reviewing
mdrows taller thanlgyarn lint:stylesPR Checklist
As the author of this PR, before marking ready for review, confirm you:
PR Checklist
As the author of this PR, before marking ready for review, confirm you:
[ ] Updated documentation and storybook examples[ ] Wrote passing tests that cover this change[ ] Tested for cross-browser consistency